Common Name Mismatch Handler For WWW Subdomain Mismatch case

chrome/browser/ssl/ssl_browser_tests.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_service.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/interstitials/security_interstitial_page_test_utils.h"
 #include "chrome/browser/net/certificate_error_reporter.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ssl/cert_logger.pb.h"
 #include "chrome/browser/ssl/cert_report_helper.h"
 #include "chrome/browser/ssl/certificate_error_report.h"
 #include "chrome/browser/ssl/certificate_reporting_test_utils.h"
 #include "chrome/browser/ssl/chrome_ssl_host_state_delegate.h"
+#include "chrome/browser/ssl/common_name_mismatch_handler.h"
 #include "chrome/browser/ssl/ssl_blocking_page.h"
+#include "chrome/browser/ssl/ssl_error_handler.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/variations/variations_associated_data.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/security_style.h"
 #include "content/public/common/ssl_status.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/download_test_observer.h"
+#include "content/public/test/test_navigation_observer.h"
 #include "content/public/test/test_renderer_host.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/net_errors.h"
 #include "net/base/test_data_directory.h"
 #include "net/cert/cert_status_flags.h"
 #include "net/cert/x509_certificate.h"
+#include "net/dns/mock_host_resolver.h"
 #include "net/ssl/ssl_info.h"
 #include "net/test/spawned_test_server/spawned_test_server.h"
+#include "net/test/test_certificate_data.h"
 #include "net/url_request/url_request_context.h"
 
 #if defined(USE_NSS_CERTS)
 #include "chrome/browser/net/nss_context.h"
 #include "net/base/crypto_module.h"
 #include "net/cert/nss_cert_database.h"
 #endif  // defined(USE_NSS_CERTS)
 
 using base::ASCIIToUTF16;
 using chrome_browser_interstitials::SecurityInterstitialIDNTest;
@@ skipping 125 matching lines @@
                       SSLOptions(SSLOptions::CERT_OK),
                       base::FilePath(kDocRoot)),
         https_server_expired_(net::SpawnedTestServer::TYPE_HTTPS,
                               SSLOptions(SSLOptions::CERT_EXPIRED),
                               base::FilePath(kDocRoot)),
         https_server_mismatched_(net::SpawnedTestServer::TYPE_HTTPS,
                                  SSLOptions(SSLOptions::CERT_MISMATCHED_NAME),
                                  base::FilePath(kDocRoot)),
         wss_server_expired_(net::SpawnedTestServer::TYPE_WSS,
                             SSLOptions(SSLOptions::CERT_EXPIRED),
-                            net::GetWebSocketTestDataDirectory()) {}
+                            net::GetWebSocketTestDataDirectory()),
+        https_server_example_domain_(
+            net::SpawnedTestServer::TYPE_HTTPS,
+            SSLOptions(SSLOptions::CERT_EXAMPLE_DOMAIN),
+            base::FilePath(kDocRoot)),
+        https_server_www_example_domain_(
+            net::SpawnedTestServer::TYPE_HTTPS,
+            SSLOptions(SSLOptions::CERT_WWW_EXAMPLE_DOMAIN),
+            base::FilePath(kDocRoot)) {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     // Browser will both run and display insecure content.
     command_line->AppendSwitch(switches::kAllowRunningInsecureContent);
     // Use process-per-site so that navigating to a same-site page in a
     // new tab will use the same process.
     command_line->AppendSwitch(switches::kProcessPerSite);
   }
 
   void CheckAuthenticatedState(WebContents* tab,
@@ skipping 198 matching lines @@
                 GetLatestHostnameReported());
     } else {
       EXPECT_EQ(std::string(), GetLatestHostnameReported());
     }
   }
 
   net::SpawnedTestServer https_server_;
   net::SpawnedTestServer https_server_expired_;
   net::SpawnedTestServer https_server_mismatched_;
   net::SpawnedTestServer wss_server_expired_;
+  net::SpawnedTestServer https_server_example_domain_;
+  net::SpawnedTestServer https_server_www_example_domain_;
 
  private:
   typedef net::SpawnedTestServer::SSLOptions SSLOptions;
 
   DISALLOW_COPY_AND_ASSIGN(SSLUITest);
 };
 
 class SSLUITestBlock : public SSLUITest {
  public:
   SSLUITestBlock() : SSLUITest() {}
@@ skipping 1778 matching lines @@
 
   ProceedThroughInterstitial(tab);
   EXPECT_TRUE(state->HasAllowException(https_server_host));
 
   ui_test_utils::NavigateToURL(browser(),
                                https_server_.GetURL("files/ssl/google.html"));
   ASSERT_FALSE(tab->GetInterstitialPage());
   EXPECT_FALSE(state->HasAllowException(https_server_host));
 }
 
+// Verifies that invoking the SSL Blocking page with a suggested URL displays
+// the common name mismatch interstitial with a link to suggested URL.
+IN_PROC_BROWSER_TEST_F(SSLUITest, SSLBlockingPageWithSuggestedURL) {
+  content::WebContents* contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  net::SSLInfo ssl_info;
+  ssl_info.cert = net::X509Certificate::CreateFromBytes(
+      reinterpret_cast<const char*>(google_der), sizeof(google_der));
+  // Create a new SSL blocking page for https://example.com with
+  // https://www.example.com as the suggested URL.
+  SSLBlockingPage* blocking_page = new SSLBlockingPage(
+      contents, net::ERR_CERT_COMMON_NAME_INVALID, ssl_info,
+      GURL("https://example.com"), 0, base::Time::NowFromSystemTime(), nullptr,
+      base::Callback<void(bool)>(), GURL("https://www.example.com"));
+

[meacer, 2015/07/28 01:18:06]

Remove empty line.

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+  blocking_page->Show();
+
+  WaitForInterstitialAttach(contents);
+  EXPECT_TRUE(
+      WaitForRenderFrameReady(contents->GetInterstitialPage()->GetMainFrame()));
+  // The interstitial should display a link to www.example.com
+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      contents->GetInterstitialPage(), "www.example.com"));
+  // Verify that the link has the text "suggest-link", the id of the
+  // link displayed.

[meacer, 2015/07/28 01:18:06]

the id of the link element displayed

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      contents->GetInterstitialPage(), "suggest-link"));
+}
+
+// Visit the URL www.example.com on a server that presents a valid certificate
+// for example.com. Verify that the common name mismatch interstitial is
+// displayed with a link to example.com.
+IN_PROC_BROWSER_TEST_F(SSLUITest, CheckWWWSubdomainMismatch) {

[meacer, 2015/07/28 01:18:06]

The naming of this test could be a bit more descriptive. How about something
like |ShouldShowWWWSubdomainMismatchInterstitial|

[Bhanu Dev, 2015/07/30 02:39:10]

That sounds better.

+  // Starts a server with a valid certificate for "example.com".
+  ASSERT_TRUE(https_server_example_domain_.Start());
+
+  host_resolver()->AddRule("example.com", "127.0.0.1");
+  host_resolver()->AddRule("www.example.com", "127.0.0.1");
+
+  GURL https_server_url =

[meacer, 2015/07/28 01:18:06]

Maybe comment that the path does not matter

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+      https_server_example_domain_.GetURL("files/ssl/google.html?a=b");
+  GURL::Replacements replacements;
+  replacements.SetHostStr("www.example.com");
+  GURL https_server_mismatched_url =
+      https_server_url.ReplaceComponents(replacements);
+
+  ui_test_utils::NavigateToURL(browser(), https_server_mismatched_url);
+
+  WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
+  WaitForInterstitialAttach(contents);
+  CheckAuthenticationBrokenState(contents, net::CERT_STATUS_COMMON_NAME_INVALID,
+                                 AuthState::SHOWING_INTERSTITIAL);
+
+  EXPECT_TRUE(

[meacer, 2015/07/28 01:18:06]

Might want to check the interstitial type here:

EXPECT_EQ(SSLBlockingPage::kTypeForTest,
contents->GetInterstitialPage()->GetDelegate()->GetTypeForTesting());

or something like that (here and elsewhere)

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+      WaitForRenderFrameReady(contents->GetInterstitialPage()->GetMainFrame()));
+  // The interstitial should display a link to www.example.com
+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      contents->GetInterstitialPage(), "example.com"));
+  // Verify that the link has the text "suggest-link", the id of the
+  // link displayed.
+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      contents->GetInterstitialPage(), "suggest-link"));

[meacer, 2015/07/28 01:18:06]

These three asserts are repeated a couple times. You can put them into a helper
method.

+}
+
+// Visit the URL example.com on a server that presents a valid certificate
+// for www.example.com. Verify that the common name mismatch interstitial is
+// displayed with a link to www.example.com.
+IN_PROC_BROWSER_TEST_F(SSLUITest, CheckWWWSubdomainMismatchInverse) {
+  // Starts a server with a valid certificate for "example.com".
+  ASSERT_TRUE(https_server_www_example_domain_.Start());
+
+  host_resolver()->AddRule("example.com", "127.0.0.1");
+  host_resolver()->AddRule("www.example.com", "127.0.0.1");
+
+  GURL https_server_url =
+      https_server_www_example_domain_.GetURL("files/ssl/google.html?a=b");
+  GURL::Replacements replacements;
+  replacements.SetHostStr("example.com");
+  GURL https_server_mismatched_url =
+      https_server_url.ReplaceComponents(replacements);
+
+  ui_test_utils::NavigateToURL(browser(), https_server_mismatched_url);
+
+  WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
+  WaitForInterstitialAttach(contents);
+  CheckAuthenticationBrokenState(contents, net::CERT_STATUS_COMMON_NAME_INVALID,
+                                 AuthState::SHOWING_INTERSTITIAL);
+
+  EXPECT_TRUE(
+      WaitForRenderFrameReady(contents->GetInterstitialPage()->GetMainFrame()));
+  // The interstitial should display a link to www.example.com
+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      contents->GetInterstitialPage(), "www.example.com"));
+  // Verify that the link has the text "suggest-link", the id of the
+  // link displayed.
+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      contents->GetInterstitialPage(), "suggest-link"));
+}
+
+// Navigate to a URL with www subdomain mismatch. Click the suggested URL link
+// and make sure the page navigates to a non SSL page.
+IN_PROC_BROWSER_TEST_F(SSLUITest,
+                       CommonNameMismatchInterstitialNavigateToSuggestedURL) {

[meacer, 2015/07/28 01:18:06]

Does this need to be a separate test? Can you not continue with clicking in the
previous test?

[Bhanu Dev, 2015/07/30 02:39:10]

Yes, that would be better. I am removing this test.

+  // Starts a server with a valid certificate for "example.com".
+  ASSERT_TRUE(https_server_example_domain_.Start());
+
+  host_resolver()->AddRule("example.com", "127.0.0.1");
+  host_resolver()->AddRule("www.example.com", "127.0.0.1");
+
+  GURL https_server_url =
+      https_server_example_domain_.GetURL("files/ssl/google.html?a=b");
+  GURL::Replacements replacements;
+  replacements.SetHostStr("www.example.com");
+  GURL https_server_mismatched_url =
+      https_server_url.ReplaceComponents(replacements);
+
+  ui_test_utils::NavigateToURL(browser(), https_server_mismatched_url);
+
+  WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
+  WaitForInterstitialAttach(contents);
+  content::RenderFrameHost* rfh =
+      contents->GetInterstitialPage()->GetMainFrame();
+  EXPECT_TRUE(WaitForRenderFrameReady(rfh));
+
+  // An interstitial should be displayed with a
+  // |CERT_STATUS_COMMON_NAME_INVALID| error.
+  CheckAuthenticationBrokenState(contents, net::CERT_STATUS_COMMON_NAME_INVALID,
+                                 AuthState::SHOWING_INTERSTITIAL);
+  // The interstitial should display a link to example.com
+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      contents->GetInterstitialPage(), "example.com"));
+  // Verify that the link has the text "suggest-link", the id of the
+  // link displayed.
+  EXPECT_TRUE(chrome_browser_interstitials::IsInterstitialDisplayingText(
+      contents->GetInterstitialPage(), "suggest-link"));
+
+  const char kClickConnectButtonJS[] =
+      "document.getElementById('suggest-link').click();";
+
+  content::TestNavigationObserver observer(contents, 1);
+  EXPECT_TRUE(content::ExecuteScript(rfh, kClickConnectButtonJS));
+  // |observer| waits for one navigation to finish.
+  observer.Wait();
+
+  CheckAuthenticatedState(contents, AuthState::NONE);
+
+  replacements.SetHostStr("example.com");
+  GURL https_server_new_url = https_server_url.ReplaceComponents(replacements);
+  // Verify that the current URL is the suggested URL.
+  EXPECT_EQ(https_server_new_url.spec(),
+            contents->GetLastCommittedURL().spec());
+}
+
+// This observer waits for the SSLErrorHandler to start an interstitial timer
+// for the given web contents.
+class SSLInterstitialTimerObserver {
+ public:
+  explicit SSLInterstitialTimerObserver(content::WebContents* web_contents);
+  ~SSLInterstitialTimerObserver();
+
+  // Waits until the interstitial delay timer in SSLErrorHandler is started.
+  void WaitForTimerStarted();
+
+ private:
+  void OnTimerStarted(content::WebContents* web_contents);
+
+  const content::WebContents* web_contents_;
+  SSLErrorHandler::TimerStartedCallback callback_;
+
+  scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
+
+  DISALLOW_COPY_AND_ASSIGN(SSLInterstitialTimerObserver);
+};
+
+SSLInterstitialTimerObserver::SSLInterstitialTimerObserver(
+    content::WebContents* web_contents)
+    : web_contents_(web_contents),
+      message_loop_runner_(new content::MessageLoopRunner) {
+  callback_ = base::Bind(&SSLInterstitialTimerObserver::OnTimerStarted,
+                         base::Unretained(this));
+  SSLErrorHandler::SetInterstitialTimerStartedCallbackForTest(&callback_);
+}
+
+SSLInterstitialTimerObserver::~SSLInterstitialTimerObserver() {
+  SSLErrorHandler::SetInterstitialTimerStartedCallbackForTest(nullptr);
+}
+
+void SSLInterstitialTimerObserver::WaitForTimerStarted() {
+  message_loop_runner_->Run();
+}
+
+void SSLInterstitialTimerObserver::OnTimerStarted(
+    content::WebContents* web_contents) {
+  if (web_contents_ == web_contents && message_loop_runner_.get())
+    message_loop_runner_->Quit();
+}
+
+// Tests this scenario:
+// - |CommonNameMismatchHandler| does not give a callback as its set into the

[meacer, 2015/07/28 01:18:06]

its -> it's

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+//   state |IGNORE_REQUESTS_FOR_TESTING|. So no suggested URL check result can
+//   arrive.
+// - A cert error triggers an interstitial timer with a very long timeout.
+// - No suggested URL check results arrive, causing the tab to appear as loading
+//   indefinitely (also because the timer has a long timeout).
+// - Stopping the page load shouldn't result in any interstitials.
+IN_PROC_BROWSER_TEST_F(SSLUITest, InterstitialStopNavigationWhileLoading) {
+  // Starts a server with a valid certificate for "example.com".
+  ASSERT_TRUE(https_server_example_domain_.Start());
+
+  host_resolver()->AddRule("example.com", "127.0.0.1");
+  host_resolver()->AddRule("www.example.com", "127.0.0.1");
+
+  GURL https_server_url =
+      https_server_example_domain_.GetURL("files/ssl/google.html?a=b");
+  GURL::Replacements replacements;
+  replacements.SetHostStr("www.example.com");
+  GURL https_server_mismatched_url =
+      https_server_url.ReplaceComponents(replacements);
+
+  WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
+  CommonNameMismatchHandler::testing_state_ =
+      CommonNameMismatchHandler::IGNORE_REQUESTS_FOR_TESTING;
+  SSLInterstitialTimerObserver interstitial_timer_observer(contents);
+
+  ui_test_utils::NavigateToURLWithDisposition(
+      browser(), https_server_mismatched_url, CURRENT_TAB,
+      ui_test_utils::BROWSER_TEST_NONE);
+  interstitial_timer_observer.WaitForTimerStarted();
+
+  EXPECT_TRUE(contents->IsLoading());
+

[meacer, 2015/07/28 01:18:06]

nit: Remove blank line

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+  content::WindowedNotificationObserver observer(
+      content::NOTIFICATION_LOAD_STOP,
+      content::NotificationService::AllSources());
+  contents->Stop();
+  observer.Wait();
+
+  EXPECT_FALSE(contents->ShowingInterstitialPage());
+  EXPECT_FALSE(contents->IsLoading());
+}
+
+// Same as above, but instead of stopping, the loading page is reloaded. The end
+// result is the same. (i.e. page load stops, no interstitials shown)
+IN_PROC_BROWSER_TEST_F(SSLUITest, InterstitialReloadNavigationWhileLoading) {
+  // Starts a server with a valid certificate for "example.com".
+  ASSERT_TRUE(https_server_example_domain_.Start());
+
+  host_resolver()->AddRule("example.com", "127.0.0.1");
+  host_resolver()->AddRule("www.example.com", "127.0.0.1");
+
+  GURL https_server_url =
+      https_server_example_domain_.GetURL("files/ssl/google.html?a=b");
+  GURL::Replacements replacements;
+  replacements.SetHostStr("www.example.com");
+  GURL https_server_mismatched_url =
+      https_server_url.ReplaceComponents(replacements);
+
+  WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
+  CommonNameMismatchHandler::testing_state_ =
+      CommonNameMismatchHandler::IGNORE_REQUESTS_FOR_TESTING;
+  SSLInterstitialTimerObserver interstitial_timer_observer(contents);
+
+  ui_test_utils::NavigateToURLWithDisposition(
+      browser(), https_server_mismatched_url, CURRENT_TAB,
+      ui_test_utils::BROWSER_TEST_NONE);
+  interstitial_timer_observer.WaitForTimerStarted();
+
+  EXPECT_TRUE(contents->IsLoading());
+

[meacer, 2015/07/28 01:18:07]

Remove blank line

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+  content::TestNavigationObserver observer(contents, 1);
+  chrome::Reload(browser(), CURRENT_TAB);
+  observer.Wait();
+
+  EXPECT_FALSE(contents->ShowingInterstitialPage());
+  EXPECT_FALSE(contents->IsLoading());
+}
+
+// Same as above, but instead of reloading, the page is navigated away. The
+// new page should load, and no interstitials should be shown.
+IN_PROC_BROWSER_TEST_F(SSLUITest, InterstitialNavigateAwayWhileLoading) {
+  // Starts a server with a valid certificate for "example.com".
+  ASSERT_TRUE(https_server_example_domain_.Start());
+
+  host_resolver()->AddRule("example.com", "127.0.0.1");
+  host_resolver()->AddRule("www.example.com", "127.0.0.1");
+
+  GURL https_server_url =
+      https_server_example_domain_.GetURL("files/ssl/google.html?a=b");
+  GURL::Replacements replacements;
+  replacements.SetHostStr("www.example.com");
+  GURL https_server_mismatched_url =
+      https_server_url.ReplaceComponents(replacements);
+
+  WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
+  CommonNameMismatchHandler::testing_state_ =
+      CommonNameMismatchHandler::IGNORE_REQUESTS_FOR_TESTING;
+  SSLInterstitialTimerObserver interstitial_timer_observer(contents);
+
+  ui_test_utils::NavigateToURLWithDisposition(
+      browser(), https_server_mismatched_url, CURRENT_TAB,
+      ui_test_utils::BROWSER_TEST_NONE);
+  interstitial_timer_observer.WaitForTimerStarted();
+
+  EXPECT_TRUE(contents->IsLoading());
+

[meacer, 2015/07/28 01:18:06]

Remove blank line

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+  content::TestNavigationObserver observer(contents, 1);
+  browser()->OpenURL(content::OpenURLParams(GURL("https://google.com"),
+                                            content::Referrer(), CURRENT_TAB,
+                                            ui::PAGE_TRANSITION_TYPED, false));
+  // |observer| waits for one navigation to finish.

[meacer, 2015/07/28 01:18:06]

comment not necessary

[Bhanu Dev, 2015/07/30 02:39:10]

Done.

+  observer.Wait();
+
+  EXPECT_FALSE(contents->ShowingInterstitialPage());
+  EXPECT_FALSE(contents->IsLoading());
+}
+
 class SSLBlockingPageIDNTest : public SecurityInterstitialIDNTest {
  protected:
   // SecurityInterstitialIDNTest implementation
   SecurityInterstitialPage* CreateInterstitial(
       content::WebContents* contents,
       const GURL& request_url) const override {
     net::SSLInfo ssl_info;
     ssl_info.cert = new net::X509Certificate(
         request_url.host(), "CA", base::Time::Max(), base::Time::Max());
-    return new SSLBlockingPage(
-        contents, net::ERR_CERT_CONTAINS_ERRORS, ssl_info, request_url, 0,
-        base::Time::NowFromSystemTime(), nullptr, base::Callback<void(bool)>());
+    return new SSLBlockingPage(contents, net::ERR_CERT_CONTAINS_ERRORS,
+                               ssl_info, request_url, 0,
+                               base::Time::NowFromSystemTime(), nullptr,
+                               base::Callback<void(bool)>(), GURL());
   }
 };
 
 IN_PROC_BROWSER_TEST_F(SSLBlockingPageIDNTest, SSLBlockingPageDecodesIDN) {
   EXPECT_TRUE(VerifyIDNDecoded());
 }
 
 // TODO(jcampan): more tests to do below.
 
 // Visit a page over https that contains a frame with a redirect.
 
 // XMLHttpRequest insecure content in synchronous mode.
 
 // XMLHttpRequest insecure content in asynchronous mode.
 
 // XMLHttpRequest over bad ssl in synchronous mode.
 
 // XMLHttpRequest over OK ssl in synchronous mode.