Common Name Mismatch Handler For WWW Subdomain Mismatch case

chrome/browser/ssl/common_name_mismatch_handler.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ssl/common_name_mismatch_handler.h"
+
+#include "base/logging.h"
+#include "base/strings/string_number_conversions.h"
+#include "chrome/browser/ssl/ssl_error_classification.h"
+#include "net/base/load_flags.h"
+#include "net/http/http_response_headers.h"
+#include "net/http/http_util.h"
+#include "net/url_request/url_request_status.h"
+
+CommonNameMismatchHandler::CommonNameMismatchHandler(
+    const GURL request_url,
+    const scoped_refptr<net::URLRequestContextGetter>& request_context)
+    : request_url_(request_url), request_context_(request_context) {
+}
+
+CommonNameMismatchHandler::~CommonNameMismatchHandler() {
+}
+
+CommonNameMismatchHandler::TestingState

[meacer, 2015/07/28 01:18:05]

Comment with "// static" in the previous line

[Bhanu Dev, 2015/07/30 02:39:09]

Done.

+    CommonNameMismatchHandler::testing_state_ = NOT_TESTING;
+
+void CommonNameMismatchHandler::CheckSuggestedUrl(
+    const GURL& url,
+    const CheckUrlCallback& callback) {
+  // Should be used only in tests.
+  if (testing_state_ == IGNORE_REQUESTS_FOR_TESTING)
+    return;
+
+  DCHECK(CalledOnValidThread());
+  DCHECK(!CheckingSuggestedUrl());
+  DCHECK(check_url_callback_.is_null());
+
+  check_url_callback_ = callback;
+
+  // The first 0 means this can use a TestURLFetcherFactory in unit tests.

[palmer, 2015/07/27 23:56:18]

Nit: It *might* be more idiomatic to leave this comment out, and instead say:

    url_fetcher_ = net::URLFetcher::Create(0 /* testing ID */, url,
net::URLFetcher::HEAD, this);

[Bhanu Dev, 2015/07/30 02:39:09]

Done.

+  url_fetcher_ = net::URLFetcher::Create(0, url, net::URLFetcher::HEAD, this);
+  url_fetcher_->SetAutomaticallyRetryOn5xx(false);
+  url_fetcher_->SetRequestContext(request_context_.get());
+
+  // Can't safely use net::LOAD_DISABLE_CERT_REVOCATION_CHECKING here,
+  // since then the connection may be reused without checking the cert.
+  url_fetcher_->SetLoadFlags(
+      net::LOAD_BYPASS_CACHE | net::LOAD_DO_NOT_SAVE_COOKIES |
+      net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SEND_AUTH_DATA);
+  url_fetcher_->Start();
+}
+
+void CommonNameMismatchHandler::OnURLFetchComplete(
+    const net::URLFetcher* source) {
+  DCHECK(CalledOnValidThread());
+  DCHECK(CheckingSuggestedUrl());
+  DCHECK_EQ(url_fetcher_.get(), source);
+  DCHECK(!check_url_callback_.is_null());
+
+  Results results;
+  GetSuggestedUrlCheckResult(url_fetcher_.get(), &results);
+  CheckUrlCallback callback = check_url_callback_;
+  url_fetcher_.reset();
+  check_url_callback_.Reset();
+  callback.Run(results);
+}
+
+// Takes a net::URLFetcher that has finished trying to retrieve the test
+// URL, and returns a CaptivePortalService::Result based on its result.

[meacer, 2015/07/28 01:18:05]

The comment is referring to captive portals :)

[Bhanu Dev, 2015/07/30 02:39:09]

Copied it from captive portal code :P . Changing the comment.

+void CommonNameMismatchHandler::GetSuggestedUrlCheckResult(
+    const net::URLFetcher* url_fetcher,
+    Results* results) const {
+  DCHECK(results);
+  DCHECK(!url_fetcher->GetStatus().is_io_pending());
+
+  results->result = RESULT_SUGGESTED_URL_INVALID;
+
+  // |suggested_url| and |landing_url| can be different in case of a redirect.
+  const GURL& suggested_url = url_fetcher->GetOriginalURL();
+  const GURL& landing_url = url_fetcher->GetURL();
+
+  // Make sure the |landing_url| is a valid https page.
+  if (url_fetcher->GetResponseCode() == 200 &&
+      landing_url.SchemeIsCryptographic() &&
+      landing_url.host() != request_url_.host()) {

[meacer, 2015/07/28 01:18:05]

I suppose we are OK with redirects to other origins here? E.g. www.example.com
pings example.com which redirects to foo.com. The user will end up on foo.com.

[Bhanu Dev, 2015/07/30 02:39:09]

I think it is OK. But, I do not know how the user is conveyed of this, as the
info bar does not display where he is redirected to.

+    results->result = RESULT_SUGGESTED_URL_VALID;
+    // Display |suggested_url| to user even if it redirects to |landing_url|.
+    results->suggested_url = suggested_url;
+  }
+}
+
+bool CommonNameMismatchHandler::GetSuggestedUrl(
+    const GURL& request_url,
+    const std::vector<std::string>& dns_names,
+    GURL* suggested_url) {
+  std::string host_name = request_url.host();
+  std::string www_mismatch_host_name;

[meacer, 2015/07/28 01:18:05]

nit:  www_mismatch_hostname?

[Bhanu Dev, 2015/07/30 02:39:09]

Done.

+  if (!SSLErrorClassification::GetWWWSubDomainMatch(host_name, dns_names,
+                                                    &www_mismatch_host_name)) {
+    return false;
+  } else {
+    // The full URL should be pinged, not just the new host name. So, get the

[meacer, 2015/07/28 01:18:05]

host name -> hostname here and other places

[Bhanu Dev, 2015/07/30 02:39:09]

Done.

+    // |suggested_url| with the |request_url|'s host name replaced with
+    // new hostname. Keep resource path, query params the same.
+    GURL::Replacements replacements;
+    replacements.SetHostStr(www_mismatch_host_name);
+    *suggested_url = request_url.ReplaceComponents(replacements);
+    return true;
+  }
+}
+
+bool CommonNameMismatchHandler::CheckingSuggestedUrl() const {
+  return url_fetcher_.get() != NULL;
+}