Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1223173008: Fix BLE register Dbus interactions. (Closed)

Created:
5 years, 5 months ago by rkc
Modified:
5 years, 5 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org, kalq_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BLE register Dbus interactions. Currently the data going to BlueZ for the advertising calls is not in the correct format. This CL fixes various issues causing problems. R=armansito@chromium.org, jamuraa@chromium.org BUG=496988 Committed: https://crrev.com/ab23b18bc2937ff716e42805105fe417c829b60c Cr-Commit-Position: refs/heads/master@{#338933}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -24 lines) Patch
M chromeos/dbus/bluetooth_le_advertisement_service_provider.cc View 1 5 chunks +23 lines, -5 lines 0 comments Download
M chromeos/dbus/bluetooth_le_advertising_manager_client.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_advertisement_chromeos.cc View 1 5 chunks +36 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
rkc
5 years, 5 months ago (2015-07-09 20:58:37 UTC) #1
rkc
5 years, 5 months ago (2015-07-09 20:59:06 UTC) #2
armansito
https://codereview.chromium.org/1223173008/diff/1/chromeos/dbus/bluetooth_le_advertisement_service_provider.cc File chromeos/dbus/bluetooth_le_advertisement_service_provider.cc (right): https://codereview.chromium.org/1223173008/diff/1/chromeos/dbus/bluetooth_le_advertisement_service_provider.cc#newcode261 chromeos/dbus/bluetooth_le_advertisement_service_provider.cc:261: void AppendArrayVariantOfStrings(dbus::MessageWriter* dict_writer, Do you mean AppendVariantArrayOfStrings? https://codereview.chromium.org/1223173008/diff/1/chromeos/dbus/bluetooth_le_advertisement_service_provider.cc#newcode266 chromeos/dbus/bluetooth_le_advertisement_service_provider.cc:266: ...
5 years, 5 months ago (2015-07-09 21:03:35 UTC) #3
rkc
https://codereview.chromium.org/1223173008/diff/1/chromeos/dbus/bluetooth_le_advertisement_service_provider.cc File chromeos/dbus/bluetooth_le_advertisement_service_provider.cc (right): https://codereview.chromium.org/1223173008/diff/1/chromeos/dbus/bluetooth_le_advertisement_service_provider.cc#newcode261 chromeos/dbus/bluetooth_le_advertisement_service_provider.cc:261: void AppendArrayVariantOfStrings(dbus::MessageWriter* dict_writer, On 2015/07/09 21:03:35, armansito wrote: > ...
5 years, 5 months ago (2015-07-15 20:03:54 UTC) #4
armansito
lgtm
5 years, 5 months ago (2015-07-15 21:24:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223173008/20001
5 years, 5 months ago (2015-07-15 21:26:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-15 22:25:19 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 22:27:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab23b18bc2937ff716e42805105fe417c829b60c
Cr-Commit-Position: refs/heads/master@{#338933}

Powered by Google App Engine
This is Rietveld 408576698