Issue 1223173003: Rename .sdkext to _sdkext and fix sky_tool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1223173003: Rename .sdkext to _sdkext and fix sky_tool (Closed)

Created:
5 years, 5 months ago by Cutch

Modified:
5 years, 5 months ago

Reviewers:
eseidel1, abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Rename .sdkext to _sdkext and fix sky_tool - Pub doesn't publish dot files (who knew?!) - sky_tool was referencing a variable that doesn't exist R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8879bfdfac5a43fa8b590530d0cc237f80465443

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -9 lines)			Patch
M	mojo/public/dart/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
D	mojo/public/dart/lib/.sdkext	View		1 chunk	+0 lines, -3 lines	0 comments	Download
A +	mojo/public/dart/lib/_sdkext	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sky/sdk/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	sky/sdk/lib/.sdkext	View		1 chunk	+0 lines, -5 lines	0 comments	Download
A +	sky/sdk/lib/_sdkext	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sky/sdk/lib/sky_tool	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

5 years, 5 months ago (2015-07-09 13:49:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8879bfdfac5a43fa8b590530d0cc237f80465443 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages