Issue 1223163004: Merge to M44: Fix heap use after free in Document::DoFieldDelay and Document::delay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1223163004: Merge to M44: Fix heap use after free in Document::DoFieldDelay and Document::delay (Closed)

Created:
5 years, 5 months ago by Lei Zhang

Modified:
5 years, 5 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@2403

Target Ref:
refs/heads/chromium/2403

Visibility:
Public.

More Reviews

Description

Merge to M44: Fix heap use after free in Document::DoFieldDelay and Document::delay This fix removes CJS_DelayData object from m_DelayData array and copies them to a new array, before processing them. So contents of m_DelayData array cannot be used after they get freed. BUG=487928 R=tsepez@chromium.org TEST= Chrome pdf plugin should not crash when poc_stable,testuafdocument1.pdf and testuafdocument2.pdf are viewed. see crbug.com/487928 and crbug.com/487928#c18 for more details. Review URL: https://codereview.chromium.org/1163823002 (cherry picked from commit 4ff7a4246c81a71b4f878e959b3ca304cd76ec8a) Committed: https://pdfium.googlesource.com/pdfium/+/6b8572240975fd479c176b25f5ab45c92ea090eb

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
	M	fpdfsdk/src/javascript/Document.cpp	View		4 chunks	+23 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

5 years, 5 months ago (2015-07-13 21:20:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6b8572240975fd479c176b25f5ab45c92ea090eb (presubmit successful).

Expand Messages | Collapse Messages