Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: sky/sdk/lib/widgets/popup_menu.dart

Issue 1223153004: Make the drawer, popup menus, dialogs, and settings page scrollable. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/widgets/fixed_height_scrollable.dart ('k') | sky/sdk/lib/widgets/scrollable_viewport.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/popup_menu.dart
diff --git a/sky/sdk/lib/widgets/popup_menu.dart b/sky/sdk/lib/widgets/popup_menu.dart
index f09d0707bafed007cedf86009bd53efb8566c968..44c168f54399c63398ca31b119968f7e7783db33 100644
--- a/sky/sdk/lib/widgets/popup_menu.dart
+++ b/sky/sdk/lib/widgets/popup_menu.dart
@@ -13,6 +13,7 @@ import '../theme/shadows.dart';
import 'animated_component.dart';
import 'basic.dart';
import 'popup_menu_item.dart';
+import 'scrollable_viewport.dart';
const Duration _kMenuOpenDuration = const Duration(milliseconds: 300);
const Duration _kMenuCloseDuration = const Duration(milliseconds: 200);
@@ -146,12 +147,14 @@ class PopupMenu extends AnimatedComponent {
),
child: new ShrinkWrapWidth(
stepWidth: _kMenuWidthStep,
- child: new Container(
- padding: const EdgeDims.symmetric(
- horizontal: _kMenuHorizontalPadding,
- vertical: _kMenuVerticalPadding
- ),
- child: new Block(children)
+ child: new ScrollableViewport(
+ child: new Container(
+ padding: const EdgeDims.symmetric(
+ horizontal: _kMenuHorizontalPadding,
+ vertical: _kMenuVerticalPadding
+ ),
+ child: new Block(children)
+ )
)
)
)
« no previous file with comments | « sky/sdk/lib/widgets/fixed_height_scrollable.dart ('k') | sky/sdk/lib/widgets/scrollable_viewport.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698