sky/sdk/lib/widgets/popup_menu.dart - Issue 1223153004: Make the drawer, popup menus, dialogs, and settings page scrollable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/popup_menu.dart

Issue 1223153004: Make the drawer, popup menus, dialogs, and settings page scrollable. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sky/sdk/lib/rendering/object.dart ('K') | « sky/sdk/lib/widgets/fixed_height_scrollable.dart ('k') | sky/sdk/lib/widgets/scrollable_viewport.dart » ('j') | sky/sdk/lib/widgets/scrollable_viewport.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/sdk/lib/widgets/popup_menu.dart

diff --git a/sky/sdk/lib/widgets/popup_menu.dart b/sky/sdk/lib/widgets/popup_menu.dart

index bf357eece3917eefdeef1d56a1781fbc1d208ba2..2cf172ad7490a96d1c9eede5fc130e46a56c3cbc 100644

--- a/sky/sdk/lib/widgets/popup_menu.dart

+++ b/sky/sdk/lib/widgets/popup_menu.dart

@@ -13,6 +13,7 @@ import '../theme/shadows.dart';

import 'animated_component.dart';

import 'basic.dart';

import 'popup_menu_item.dart';

+import 'scrollable_viewport.dart';

const double _kMenuOpenDuration = 300.0;

const double _kMenuCloseDuration = 200.0;

@@ -122,7 +123,9 @@ class PopupMenu extends AnimatedComponent {

horizontal: _kMenuHorizontalPadding,

vertical: _kMenuVerticalPadding

- child: new Block(children)

+ child: new ScrollableViewport(

+ child: new Block(children)

+ )

)