Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: sky/sdk/lib/rendering/object.dart

Issue 1223153004: Make the drawer, popup menus, dialogs, and settings page scrollable. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/rendering/object.dart
diff --git a/sky/sdk/lib/rendering/object.dart b/sky/sdk/lib/rendering/object.dart
index 2b80f396b49aeb99b589c608a1bf536e474eb509..465de903ff4945ffd79a0d7a239f765b67d65067 100644
--- a/sky/sdk/lib/rendering/object.dart
+++ b/sky/sdk/lib/rendering/object.dart
@@ -199,8 +199,8 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
_debugMutationsLocked = false;
return true;
});
- } catch (e) {
- print('Exception raised during layout:\n${e}\nContext:\n${this}');
+ } catch (e, stack) { // TODO(ianh): Figure out how we can not ask for the stack trace in prod mode
abarth-chromium 2015/07/09 23:39:35 Please don't check this in.
+ print('Exception raised during layout:\n${e}\n${stack}\nContext:\n${this}');
return;
}
_needsLayout = false;
@@ -340,8 +340,6 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
node._updatePaintingCanvas();
};
assert(_nodesNeedingPaint.length == 0);
- } catch (e) {
- print('Exception raised during flushPaint:\n${e}');
} finally {
_debugDoingPaint = false;
}
@@ -355,8 +353,8 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
_needsPaint = false;
try {
_paintOnCanvas(canvas, Offset.zero);
- } catch (e) {
- print('Exception raised during _updatePaintingCanvas:\n${e}\nContext:\n${this}');
+ } catch (e, stack) { // TODO(ianh): Figure out how we can not ask for the stack trace in prod mode
abarth-chromium 2015/07/09 23:39:35 ditto
+ print('Exception raised during paint:\n${e}\n${stack}\nContext:\n${this}');
return;
}
assert(!_needsLayout); // check that the paint() method didn't mark us dirty again

Powered by Google App Engine
This is Rietveld 408576698