Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1870)

Unified Diff: sky/sdk/example/stocks/lib/stock_settings.dart

Issue 1223153004: Make the drawer, popup menus, dialogs, and settings page scrollable. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/example/stocks/lib/stock_settings.dart
diff --git a/sky/sdk/example/stocks/lib/stock_settings.dart b/sky/sdk/example/stocks/lib/stock_settings.dart
index 98088ae7f048eaf9888f3de4d0d1bb0b8f00855a..3da12e14a1c1112b0205a6497cf05efd319a4b8c 100644
--- a/sky/sdk/example/stocks/lib/stock_settings.dart
+++ b/sky/sdk/example/stocks/lib/stock_settings.dart
@@ -4,14 +4,15 @@
import 'package:sky/widgets/basic.dart';
import 'package:sky/widgets/checkbox.dart';
-import 'package:sky/widgets/switch.dart';
-import 'package:sky/widgets/flat_button.dart';
import 'package:sky/widgets/dialog.dart';
+import 'package:sky/widgets/flat_button.dart';
import 'package:sky/widgets/icon_button.dart';
import 'package:sky/widgets/material.dart';
import 'package:sky/widgets/menu_item.dart';
import 'package:sky/widgets/navigator.dart';
import 'package:sky/widgets/scaffold.dart';
+import 'package:sky/widgets/scrollable_viewport.dart';
+import 'package:sky/widgets/switch.dart';
import 'package:sky/widgets/tool_bar.dart';
import 'stock_types.dart';
@@ -91,24 +92,26 @@ class StockSettings extends StatefulComponent {
type: MaterialType.canvas,
child: new Container(
padding: const EdgeDims.symmetric(vertical: 20.0),
- child: new Block([
- new MenuItem(
- icon: 'action/thumb_up',
- onPressed: () => _confirmOptimismChange(),
- children: [
- new Flexible(child: new Text('Everything is awesome')),
- new Checkbox(value: optimism == StockMode.optimistic, onChanged: _handleOptimismChanged)
- ]
- ),
- new MenuItem(
- icon: 'action/backup',
- onPressed: () { _handleBackupChanged(!(backup == BackupMode.enabled)); },
- children: [
- new Flexible(child: new Text('Back up stock list to the cloud')),
- new Switch(value: backup == BackupMode.enabled, onChanged: _handleBackupChanged)
- ]
- ),
- ])
+ child: new ScrollableViewport(
+ child: new Block([
abarth-chromium 2015/07/09 23:39:34 We should combine these into a ScrollableBlock
+ new MenuItem(
+ icon: 'action/thumb_up',
+ onPressed: () => _confirmOptimismChange(),
+ children: [
+ new Flexible(child: new Text('Everything is awesome')),
+ new Checkbox(value: optimism == StockMode.optimistic, onChanged: _handleOptimismChanged)
+ ]
+ ),
+ new MenuItem(
+ icon: 'action/backup',
+ onPressed: () { _handleBackupChanged(!(backup == BackupMode.enabled)); },
+ children: [
+ new Flexible(child: new Text('Back up stock list to the cloud')),
+ new Switch(value: backup == BackupMode.enabled, onChanged: _handleBackupChanged)
+ ]
+ ),
+ ])
+ )
)
);
}

Powered by Google App Engine
This is Rietveld 408576698