Make the drawer, popup menus, dialogs, and settings page scrollable.

sky/sdk/lib/rendering/block.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import 'dart:math' as math;
 
 import 'box.dart';
 import 'object.dart';
 
 class BlockParentData extends BoxParentData with ContainerParentDataMixin<RenderBox> { }
@@ skipping 91 matching lines @@
   }
 
   double getMaxIntrinsicHeight(BoxConstraints constraints) {
     return _getIntrinsicHeight(constraints);
   }
 
   double computeDistanceToActualBaseline(TextBaseline baseline) {
     return defaultComputeDistanceToFirstActualBaseline(baseline);
   }
 
-  bool _hasVisualOverflow = false;
-
   void performLayout() {
+    assert(constraints.maxHeight >= double.INFINITY);
     super.performLayout();
     size = constraints.constrain(new Size(constraints.maxWidth, childrenHeight));
     assert(!size.isInfinite);
-
-    // FIXME(eseidel): Block lays out its children with unconstrained height
-    // yet itself remains constrained. Remember that our children wanted to
-    // be taller than we are so we know to clip them (and not cause confusing
-    // mismatch of painting vs. hittesting).
-    _hasVisualOverflow = childrenHeight > size.height;
   }
 
   void paint(PaintingCanvas canvas, Offset offset) {
-    if (_hasVisualOverflow) {
-      canvas.save();
-      canvas.clipRect(offset & size);
-    }
     defaultPaint(canvas, offset);
-    if (_hasVisualOverflow) {
-      canvas.restore();
-    }
   }
 
   void hitTestChildren(HitTestResult result, { Point position }) {
     defaultHitTestChildren(result, position: position);
   }
 
 }
 
 class RenderBlockViewport extends RenderBlockBase {
 
@@ skipping 52 matching lines @@
 
   bool get sizedByParent => true;
 
   void performResize() {
     size = constraints.biggest;
     assert(!size.isInfinite);
   }
 
   bool get debugDoesLayoutWithCallback => true;
   void performLayout() {
+    assert(constraints.maxHeight < double.INFINITY);
     if (_callback != null) {
       try {
         _inCallback = true;
         invokeLayoutCallback(_callback);
       } finally {
         _inCallback = false;
       }
     }
     super.performLayout();
   }
 
   void paint(PaintingCanvas canvas, Offset offset) {
     canvas.save();
     canvas.clipRect(offset & size);
     defaultPaint(canvas, offset.translate(0.0, startOffset));
     canvas.restore();
   }
 
   void hitTestChildren(HitTestResult result, { Point position }) {
     defaultHitTestChildren(result, position: position + new Offset(0.0, -startOffset));
   }
 
 }