ui/message_center/views/notification_view.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/notification_view.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/message_center/views/notification_view.cc

diff --git a/ui/message_center/views/notification_view.cc b/ui/message_center/views/notification_view.cc

index 5f314b5dfbc64c6f9194fa0893bd335749da04ed..e9294f8e4eb857fe5bd259741cbefee8b71610f6 100644

--- a/ui/message_center/views/notification_view.cc

+++ b/ui/message_center/views/notification_view.cc

@@ -334,7 +334,8 @@ void NotificationView::SetAccessibleName(const Notification& notification) {

accessible_lines.push_back(items[i].title + base::ASCIIToUTF16(" ") +

items[i].message);

}

- set_accessible_name(JoinString(accessible_lines, '\n'));

+ set_accessible_name(

+ base::JoinString(accessible_lines, base::ASCIIToUTF16("\n")));

}

NotificationView::NotificationView(MessageCenterController* controller,

« no previous file with comments | « ui/message_center/views/bounded_label.cc ('k') | ui/views/controls/table/table_view.cc » ('j') | no next file with comments »