extensions/browser/api/management/management_api.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/management/management_api.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/management/management_api.cc

diff --git a/extensions/browser/api/management/management_api.cc b/extensions/browser/api/management/management_api.cc

index 468c0c5d94ed29d3f975bf4b457ba33c4c351324..1581414dd312425924563f5f80b3542f34743310 100644

--- a/extensions/browser/api/management/management_api.cc

+++ b/extensions/browser/api/management/management_api.cc

@@ -499,7 +499,7 @@ void ManagementSetEnabledFunction::OnRequirementsChecked(

} else {

// TODO(devlin): Should we really be noisy here all the time?

Respond(Error(keys::kMissingRequirementsError,

- JoinString(requirements_errors, ' ')));

+ base::JoinString(requirements_errors, " ")));

}