content/browser/accessibility/dump_accessibility_browsertest_base.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/dump_accessibility_browsertest_base.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/accessibility_tree_formatter_utils_win.cc ('k') | content/browser/gpu/gpu_data_manager_impl_private.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/dump_accessibility_browsertest_base.cc

diff --git a/content/browser/accessibility/dump_accessibility_browsertest_base.cc b/content/browser/accessibility/dump_accessibility_browsertest_base.cc

index f6da92c1b4d9f07e993a7b8a4f64edfca0b80000..2a9a1ef6246c3ba21935116dbe2ad446af5d2b03 100644

--- a/content/browser/accessibility/dump_accessibility_browsertest_base.cc

+++ b/content/browser/accessibility/dump_accessibility_browsertest_base.cc

@@ -202,7 +202,7 @@ void DumpAccessibilityTestBase::RunTest(

// file length differences are found.

expected_lines.push_back(kMarkEndOfFile);

actual_lines.push_back(kMarkEndOfFile);

- std::string actual_contents = JoinString(actual_lines, "\n");

+ std::string actual_contents = base::JoinString(actual_lines, "\n");

std::vector<int> diff_lines = DiffLines(expected_lines, actual_lines);

bool is_different = diff_lines.size() > 0;