components/view_manager/test_change_tracker.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/view_manager/test_change_tracker.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/view_manager/test_change_tracker.cc

diff --git a/components/view_manager/test_change_tracker.cc b/components/view_manager/test_change_tracker.cc

index 33e0f96580de0a54673c207a87028eefcdcb68eb..ac7183d839a3daab96a435544e7ad3e28f127a19 100644

--- a/components/view_manager/test_change_tracker.cc

+++ b/components/view_manager/test_change_tracker.cc

@@ -133,7 +133,7 @@ std::string ChangeViewDescription(const std::vector<Change>& changes) {

std::vector<std::string> view_strings(changes[0].views.size());

for (size_t i = 0; i < changes[0].views.size(); ++i)

view_strings[i] = "[" + changes[0].views[i].ToString() + "]";

- return JoinString(view_strings, ',');

+ return base::JoinString(view_strings, ",");

}

TestView ViewDataToTestView(const ViewDataPtr& data) {