components/signin/core/browser/gaia_cookie_manager_service.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/gaia_cookie_manager_service.cc

diff --git a/components/signin/core/browser/gaia_cookie_manager_service.cc b/components/signin/core/browser/gaia_cookie_manager_service.cc

index 4beff36cbccc78951d073ada993e79b2978602a5..dcc74aefbeeb8347f378533f0793128ffcecea8d 100644

--- a/components/signin/core/browser/gaia_cookie_manager_service.cc

+++ b/components/signin/core/browser/gaia_cookie_manager_service.cc

@@ -114,7 +114,7 @@ GaiaCookieManagerService::ExternalCcResultFetcher::GetExternalCcResult() {

++it) {

results.push_back(it->first + ":" + it->second);

}

- return JoinString(results, ",");

+ return base::JoinString(results, ",");

}

void GaiaCookieManagerService::ExternalCcResultFetcher::Start() {