components/search_engines/template_url.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/template_url.cc

diff --git a/components/search_engines/template_url.cc b/components/search_engines/template_url.cc

index 8202fa4483c0d7d0569b9bf5da797ff44b1c2f26..dbb74fc77853e1fe3c15533b7a1740a360ecf6fe 100644

--- a/components/search_engines/template_url.cc

+++ b/components/search_engines/template_url.cc

@@ -337,7 +337,7 @@ std::string TemplateURLRef::ReplaceSearchTerms(

return url;

GURL::Replacements replacements;

- std::string query_str = JoinString(query_params, "&");

+ std::string query_str = base::JoinString(query_params, "&");

replacements.SetQueryStr(query_str);

return gurl.ReplaceComponents(replacements).possibly_invalid_spec();

}