components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc

diff --git a/components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc b/components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc

index 7c07fc2b243c74b835c3fcccb232a2df97c33ec8..834e42a6cb3ebb9ce72e420a8b6b9772a3d7f9bb 100644

--- a/components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc

+++ b/components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc

@@ -93,7 +93,7 @@ void CryptAuthGCMManagerImpl::OnMessage(const std::string& app_id,

PA_LOG(INFO) << "GCM message received:\n"

<< " sender_id: " << message.sender_id << "\n"

<< " collapse_key: " << message.collapse_key << "\n"

- << " data:\n " << JoinString(fields, "\n ");

+ << " data:\n " << base::JoinString(fields, "\n ");

if (message.data.find(kRegistrationTickleTypeKey) == message.data.end()) {

PA_LOG(WARNING) << "GCM message does not contain 'registrationTickleType'.";