components/policy/core/browser/policy_error_map.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/policy_error_map.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/browser/policy_error_map.cc

diff --git a/components/policy/core/browser/policy_error_map.cc b/components/policy/core/browser/policy_error_map.cc

index 04411b6d5e544df0f3e3b701b2fb30fd96601e81..3360c3d6ae5037bfbc1141b5507c17a70ccb6382 100644

--- a/components/policy/core/browser/policy_error_map.cc

+++ b/components/policy/core/browser/policy_error_map.cc

@@ -186,7 +186,7 @@ base::string16 PolicyErrorMap::GetErrors(const std::string& policy) {

std::vector<base::string16> list;

for (const_iterator it = range.first; it != range.second; ++it)

list.push_back(it->second);

- return JoinString(list, '\n');

+ return base::JoinString(list, base::ASCIIToUTF16("\n"));

}

bool PolicyErrorMap::empty() {