components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

index 8717fcb14cb2420b0ae01be67d106db1d65d18ff..6a550849739008c179402980b05abe9d962ae569 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc

@@ -398,7 +398,7 @@ void DataReductionProxyRequestOptions::RegenerateRequestHeaderValue() {

for (const auto& experiment : experiments_)

headers.push_back(FormatOption(kExperimentsOption, experiment));

- header_value_ = JoinString(headers, ", ");

+ header_value_ = base::JoinString(headers, ", ");

}

} // namespace data_reduction_proxy