components/autofill/core/common/password_form.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/common/password_form.cc

diff --git a/components/autofill/core/common/password_form.cc b/components/autofill/core/common/password_form.cc

index fdd6144cb3a05639f6cc48649ecc89af1f0601e9..0f369dbd750387a162f52c1c09c21a60ee6f2a5a 100644

--- a/components/autofill/core/common/password_form.cc

+++ b/components/autofill/core/common/password_form.cc

@@ -36,7 +36,8 @@ void PasswordFormToJSON(const PasswordForm& form,

target->SetBoolean("new_password_marked_by_site",

form.new_password_marked_by_site);

target->SetString("other_possible_usernames",

- JoinString(form.other_possible_usernames, '|'));

+ base::JoinString(form.other_possible_usernames,

+ base::ASCIIToUTF16("|")));

target->SetBoolean("blacklisted", form.blacklisted_by_user);

target->SetBoolean("preferred", form.preferred);

target->SetBoolean("ssl_valid", form.ssl_valid);