Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: components/autofill/core/browser/contact_info.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/contact_info.cc
diff --git a/components/autofill/core/browser/contact_info.cc b/components/autofill/core/browser/contact_info.cc
index 6e13759b1f528d81eaefbf371e04c4418d562c25..ccb45ccdecd4a3850aa52386b62a7f60d621e56e 100644
--- a/components/autofill/core/browser/contact_info.cc
+++ b/components/autofill/core/browser/contact_info.cc
@@ -125,7 +125,7 @@ NameParts SplitName(const base::string16& name) {
std::vector<base::string16> family_tokens(reverse_family_tokens.rbegin(),
reverse_family_tokens.rend());
- parts.family = JoinString(family_tokens, base::char16(' '));
+ parts.family = base::JoinString(family_tokens, base::ASCIIToUTF16(" "));
// Take the last remaining token as the middle name (if there are at least 2
// tokens).
@@ -135,7 +135,7 @@ NameParts SplitName(const base::string16& name) {
}
// Remainder is given name.
- parts.given = JoinString(name_tokens, base::char16(' '));
+ parts.given = base::JoinString(name_tokens, base::ASCIIToUTF16(" "));
return parts;
}
@@ -262,7 +262,7 @@ base::string16 NameInfo::FullName() const {
if (!family_.empty())
full_name.push_back(family_);
- return JoinString(full_name, ' ');
+ return base::JoinString(full_name, base::ASCIIToUTF16(" "));
}
base::string16 NameInfo::MiddleInitial() const {

Powered by Google App Engine
This is Rietveld 408576698