chrome/common/extensions/command.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/command.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/command.cc

diff --git a/chrome/common/extensions/command.cc b/chrome/common/extensions/command.cc

index ba42e1c6def0fe420edabde9c7fa94191b75548c..fc4b47bc44e7b6ffcf867230ab5196b6d319fa7f 100644

--- a/chrome/common/extensions/command.cc

+++ b/chrome/common/extensions/command.cc

@@ -272,7 +272,7 @@ std::string NormalizeShortcutSuggestion(const std::string& suggestion,

else if (tokens[i] == values::kKeyMacCtrl)

tokens[i] = values::kKeyCtrl;

}

- return JoinString(tokens, '+');

+ return base::JoinString(tokens, "+");

}

} // namespace