chrome/browser/ui/cocoa/global_error_bubble_controller.mm - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/global_error_bubble_controller.mm

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/global_error_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/global_error_bubble_controller.mm b/chrome/browser/ui/cocoa/global_error_bubble_controller.mm

index c2604d930b289a2121001188358422e3aecebc30..d62343f037aae9944845b26a45cd3f7686f2fb36 100644

--- a/chrome/browser/ui/cocoa/global_error_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/global_error_bubble_controller.mm

@@ -82,7 +82,7 @@ class Bridge : public GlobalErrorBubbleViewBase {

[title_ setStringValue:SysUTF16ToNSString(error_->GetBubbleViewTitle())];

std::vector<base::string16> messages = error_->GetBubbleViewMessages();

- base::string16 message = JoinString(messages, '\n');

+ base::string16 message = base::JoinString(messages, base::ASCIIToUTF16("\n"));

base::scoped_nsobject<NSMutableAttributedString> messageValue(

[[NSMutableAttributedString alloc]