chrome/browser/net/firefox_proxy_settings.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/firefox_proxy_settings.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/firefox_proxy_settings.cc

diff --git a/chrome/browser/net/firefox_proxy_settings.cc b/chrome/browser/net/firefox_proxy_settings.cc

index 2b23e01d5ae1fb70156133334cc4b4b62d5e750d..203d9557f6cef98390ece7109b53116113da26eb 100644

--- a/chrome/browser/net/firefox_proxy_settings.cc

+++ b/chrome/browser/net/firefox_proxy_settings.cc

@@ -236,7 +236,7 @@ bool FirefoxProxySettings::ToProxyConfig(net::ProxyConfig* config) {

}

config->proxy_rules().bypass_rules.ParseFromStringUsingSuffixMatching(

- JoinString(proxy_bypass_list_, ';'));

+ base::JoinString(proxy_bypass_list_, ";"));

return true;

}

« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/net/predictor.cc » ('j') | no next file with comments »