chrome/browser/chromeos/input_method/input_method_manager_impl.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/input_method/input_method_manager_impl.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc

index bff428cf90affa2c97936a29952c3c3809a76663..89a42bb9f62bfe03c992f79f9cb25d8587a1bcba 100644

--- a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc

+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl.cc

@@ -610,7 +610,8 @@ void InputMethodManagerImpl::StateImpl::SetInputMethodLoginDefaultFromVPD(

manager_->MigrateInputMethods(&layouts);

PrefService* prefs = g_browser_process->local_state();

- prefs->SetString(prefs::kHardwareKeyboardLayout, JoinString(layouts, ","));

+ prefs->SetString(prefs::kHardwareKeyboardLayout,

+ base::JoinString(layouts, ","));

// This asks the file thread to save the prefs (i.e. doesn't block).

// The latest values of Local State reside in memory so we can safely