base/trace_event/trace_event_impl.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_impl.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_impl.cc

diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc

index f01a8880400f3ed55bfe1e0196965d9f301b03b9..cd8cf4aa90c46e7167682715b3a8f91618dfbd97 100644

--- a/base/trace_event/trace_event_impl.cc

+++ b/base/trace_event/trace_event_impl.cc

@@ -2352,7 +2352,7 @@ void TraceLog::AddMetadataEventsWhileLocked() {

InitializeMetadataEvent(AddEventToThreadSharedChunkWhileLocked(NULL, false),

current_thread_id,

"process_labels", "labels",

- JoinString(labels, ','));

+ base::JoinString(labels, ","));

}

// Thread sort indices.