base/debug/crash_logging.cc - Issue 1223153003: Move JoinString to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/crash_logging.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: windows Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/crash_logging.cc

diff --git a/base/debug/crash_logging.cc b/base/debug/crash_logging.cc

index f9b44490d4bd7165deb75ea066ea7ee6718a6688..058b476800da3a65bd35f3b6cb2f804533986e26 100644

--- a/base/debug/crash_logging.cc

+++ b/base/debug/crash_logging.cc

@@ -119,7 +119,7 @@ void SetCrashKeyFromAddresses(const base::StringPiece& key,

hex_backtrace.push_back(s);

}

- value = JoinString(hex_backtrace, ' ');

+ value = base::JoinString(hex_backtrace, " ");

// Warn if this exceeds the breakpad limits.

DCHECK_LE(value.length(), kBreakpadValueMax);

« no previous file with comments | « ash/system/user/user_card_view.cc ('k') | base/strings/string_util.h » ('j') | no next file with comments »