Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: android_webview/native/aw_web_contents_delegate.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/system/chromeos/tray_display.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_web_contents_delegate.cc
diff --git a/android_webview/native/aw_web_contents_delegate.cc b/android_webview/native/aw_web_contents_delegate.cc
index bc7e0264db69e34e5733b9d127e8193946ab63bc..1d22633c80a58b4502084ca41ece50e77d5cc780 100644
--- a/android_webview/native/aw_web_contents_delegate.cc
+++ b/android_webview/native/aw_web_contents_delegate.cc
@@ -16,6 +16,7 @@
#include "base/lazy_instance.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
@@ -114,7 +115,7 @@ void AwWebContentsDelegate::RunFileChooser(WebContents* web_contents,
web_contents->GetRenderViewHost()->GetRoutingID(),
mode_flags,
ConvertUTF16ToJavaString(env,
- JoinString(params.accept_types, ',')).obj(),
+ base::JoinString(params.accept_types, base::ASCIIToUTF16(","))).obj(),
params.title.empty() ? NULL :
ConvertUTF16ToJavaString(env, params.title).obj(),
params.default_file_name.empty() ? NULL :
@@ -293,7 +294,7 @@ static void FilesSelectedInChooser(
mode = FileChooserParams::Open;
}
DVLOG(0) << "File Chooser result: mode = " << mode
- << ", file paths = " << JoinString(file_path_str, ":");
+ << ", file paths = " << base::JoinString(file_path_str, ":");
rvh->FilesSelectedInChooser(files, mode);
}
« no previous file with comments | « no previous file | ash/system/chromeos/tray_display.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698