Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: content/browser/renderer_host/pepper/pepper_socket_utils.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/pepper/pepper_socket_utils.h" 5 #include "content/browser/renderer_host/pepper/pepper_socket_utils.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_COMMON_NAME, 74 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_COMMON_NAME,
75 new base::StringValue(issuer.common_name)); 75 new base::StringValue(issuer.common_name));
76 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_LOCALITY_NAME, 76 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_LOCALITY_NAME,
77 new base::StringValue(issuer.locality_name)); 77 new base::StringValue(issuer.locality_name));
78 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_STATE_OR_PROVINCE_NAME, 78 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_STATE_OR_PROVINCE_NAME,
79 new base::StringValue(issuer.state_or_province_name)); 79 new base::StringValue(issuer.state_or_province_name));
80 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_COUNTRY_NAME, 80 fields->SetField(PP_X509CERTIFICATE_PRIVATE_ISSUER_COUNTRY_NAME,
81 new base::StringValue(issuer.country_name)); 81 new base::StringValue(issuer.country_name));
82 fields->SetField( 82 fields->SetField(
83 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_NAME, 83 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_NAME,
84 new base::StringValue(JoinString(issuer.organization_names, '\n'))); 84 new base::StringValue(base::JoinString(issuer.organization_names, "\n")));
85 fields->SetField( 85 fields->SetField(
86 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_UNIT_NAME, 86 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_UNIT_NAME,
87 new base::StringValue(JoinString(issuer.organization_unit_names, '\n'))); 87 new base::StringValue(
88 base::JoinString(issuer.organization_unit_names, "\n")));
88 89
89 const net::CertPrincipal& subject = cert.subject(); 90 const net::CertPrincipal& subject = cert.subject();
90 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_COMMON_NAME, 91 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_COMMON_NAME,
91 new base::StringValue(subject.common_name)); 92 new base::StringValue(subject.common_name));
92 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_LOCALITY_NAME, 93 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_LOCALITY_NAME,
93 new base::StringValue(subject.locality_name)); 94 new base::StringValue(subject.locality_name));
94 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_STATE_OR_PROVINCE_NAME, 95 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_STATE_OR_PROVINCE_NAME,
95 new base::StringValue(subject.state_or_province_name)); 96 new base::StringValue(subject.state_or_province_name));
96 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_COUNTRY_NAME, 97 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SUBJECT_COUNTRY_NAME,
97 new base::StringValue(subject.country_name)); 98 new base::StringValue(subject.country_name));
98 fields->SetField( 99 fields->SetField(
99 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_NAME, 100 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_NAME,
100 new base::StringValue(JoinString(subject.organization_names, '\n'))); 101 new base::StringValue(
102 base::JoinString(subject.organization_names, "\n")));
101 fields->SetField( 103 fields->SetField(
102 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME, 104 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME,
103 new base::StringValue(JoinString(subject.organization_unit_names, '\n'))); 105 new base::StringValue(
106 base::JoinString(subject.organization_unit_names, "\n")));
104 107
105 const std::string& serial_number = cert.serial_number(); 108 const std::string& serial_number = cert.serial_number();
106 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER, 109 fields->SetField(PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER,
107 base::BinaryValue::CreateWithCopiedBuffer( 110 base::BinaryValue::CreateWithCopiedBuffer(
108 serial_number.data(), serial_number.length())); 111 serial_number.data(), serial_number.length()));
109 fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_BEFORE, 112 fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_BEFORE,
110 new base::FundamentalValue(cert.valid_start().ToDoubleT())); 113 new base::FundamentalValue(cert.valid_start().ToDoubleT()));
111 fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_AFTER, 114 fields->SetField(PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_AFTER,
112 new base::FundamentalValue(cert.valid_expiry().ToDoubleT())); 115 new base::FundamentalValue(cert.valid_expiry().ToDoubleT()));
113 std::string der; 116 std::string der;
114 net::X509Certificate::GetDEREncoded(cert.os_cert_handle(), &der); 117 net::X509Certificate::GetDEREncoded(cert.os_cert_handle(), &der);
115 fields->SetField( 118 fields->SetField(
116 PP_X509CERTIFICATE_PRIVATE_RAW, 119 PP_X509CERTIFICATE_PRIVATE_RAW,
117 base::BinaryValue::CreateWithCopiedBuffer(der.data(), der.length())); 120 base::BinaryValue::CreateWithCopiedBuffer(der.data(), der.length()));
118 return true; 121 return true;
119 } 122 }
120 123
121 bool GetCertificateFields(const char* der, 124 bool GetCertificateFields(const char* der,
122 uint32_t length, 125 uint32_t length,
123 ppapi::PPB_X509Certificate_Fields* fields) { 126 ppapi::PPB_X509Certificate_Fields* fields) {
124 scoped_refptr<net::X509Certificate> cert = 127 scoped_refptr<net::X509Certificate> cert =
125 net::X509Certificate::CreateFromBytes(der, length); 128 net::X509Certificate::CreateFromBytes(der, length);
126 if (!cert.get()) 129 if (!cert.get())
127 return false; 130 return false;
128 return GetCertificateFields(*cert.get(), fields); 131 return GetCertificateFields(*cert.get(), fields);
129 } 132 }
130 133
131 } // namespace pepper_socket_utils 134 } // namespace pepper_socket_utils
132 } // namespace content 135 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/gpu/gpu_data_manager_impl_private.cc ('k') | content/browser/renderer_host/pepper/pepper_tcp_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698