Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/browser/sync/profile_sync_service_android_unittest.cc

Issue 1223153003: Move JoinString to the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 90
91 std::vector<std::string> invalidation_names; 91 std::vector<std::string> invalidation_names;
92 for (syncer::ModelTypeSet::Iterator it = model_types.First(); it.Good(); 92 for (syncer::ModelTypeSet::Iterator it = model_types.First(); it.Good();
93 it.Inc()) { 93 it.Inc()) {
94 std::string notification_type; 94 std::string notification_type;
95 if (syncer::RealModelTypeToNotificationType(it.Get(), &notification_type)) 95 if (syncer::RealModelTypeToNotificationType(it.Get(), &notification_type))
96 invalidation_names.push_back(notification_type); 96 invalidation_names.push_back(notification_type);
97 } 97 }
98 98
99 std::sort(invalidation_names.begin(), invalidation_names.end()); 99 std::sort(invalidation_names.begin(), invalidation_names.end());
100 EXPECT_EQ(JoinString(invalidation_names, ", "), 100 EXPECT_EQ(base::JoinString(invalidation_names, ", "),
101 ProfileSyncServiceAndroid::ModelTypeSelectionToStringForTest( 101 ProfileSyncServiceAndroid::ModelTypeSelectionToStringForTest(
102 model_type_selection)); 102 model_type_selection));
103 } 103 }
OLDNEW
« no previous file with comments | « chrome/browser/sxs_linux.cc ('k') | chrome/browser/sync_file_system/drive_backend/metadata_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698