Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/IceClFlags.cpp

Issue 1223133007: Factor out prelowerPhi for 32-bit targets. Disable adv phi lowering for ARM. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: fill in wqthe random test case for more undef stuff Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile.standalone ('k') | src/IcePhiLoweringImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceClFlags.cpp
diff --git a/src/IceClFlags.cpp b/src/IceClFlags.cpp
index f1aebd2dfc42a9fb1724a543f122a702377027ec..2d2e641eb50133ee090eae36264e01a38a382c2f 100644
--- a/src/IceClFlags.cpp
+++ b/src/IceClFlags.cpp
@@ -390,7 +390,15 @@ void ClFlags::getParsedClFlags(ClFlags &OutFlags) {
OutFlags.setFunctionSections(::FunctionSections);
OutFlags.setNumTranslationThreads(::NumThreads);
OutFlags.setOptLevel(::OLevel);
- OutFlags.setPhiEdgeSplit(::EnablePhiEdgeSplit);
+ if (::TargetArch == Target_ARM32) {
+ // TODO(jvoung): We need lowerPhiAssignments to handle spilling
+ // more than one register, since some ARM lowerAssign sequences
+ // may require more than one register. For now, disable PhiEdgeSplit
+ // to avoid requiring lowerPhiAssignments.
+ OutFlags.setPhiEdgeSplit(false);
+ } else {
+ OutFlags.setPhiEdgeSplit(::EnablePhiEdgeSplit);
+ }
OutFlags.setRandomSeed(::RandomSeed);
OutFlags.setShouldDoNopInsertion(::ShouldDoNopInsertion);
OutFlags.setShouldRandomizeRegAlloc(::RandomizeRegisterAllocation);
« no previous file with comments | « Makefile.standalone ('k') | src/IcePhiLoweringImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698