Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 122313007: [Autofill] Style cleanup: Move AutofillProfileSyncableService into the autofill namespace. (Closed)

Created:
6 years, 11 months ago by Ilya Sherman
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, browser-components-watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

[Autofill] Style cleanup: Move AutofillProfileSyncableService into the autofill namespace. Also, re-arrange a bit of code in the implementation file for slightly clearer structuring. BUG=none TEST=none R=estade@chromium.org TBR=joi@chromium.org,zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243541

Patch Set 1 #

Patch Set 2 : Remove more unnecessary autofill:: namespace qualifiers #

Patch Set 3 : Fix mysterious Windows compile failure??? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -171 lines) Patch
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.h View 11 chunks +32 lines, -33 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 1 2 10 chunks +52 lines, -49 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc View 1 10 chunks +76 lines, -86 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Ilya Sherman
6 years, 11 months ago (2014-01-07 02:35:49 UTC) #1
Evan Stade
lgtm
6 years, 11 months ago (2014-01-07 22:08:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/122313007/40001
6 years, 11 months ago (2014-01-07 22:19:20 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43625
6 years, 11 months ago (2014-01-07 22:42:19 UTC) #4
Ilya Sherman
TBR joi@ for changes in chrome/browser/webdata and zea@ for changes in chrome/browser/sync.
6 years, 11 months ago (2014-01-07 22:50:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/122313007/40001
6 years, 11 months ago (2014-01-07 22:53:21 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242824
6 years, 11 months ago (2014-01-08 00:05:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/122313007/380001
6 years, 11 months ago (2014-01-08 00:27:51 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242925
6 years, 11 months ago (2014-01-08 02:14:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/122313007/380001
6 years, 11 months ago (2014-01-08 02:20:07 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242994
6 years, 11 months ago (2014-01-08 04:43:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/122313007/380001
6 years, 11 months ago (2014-01-08 04:45:24 UTC) #12
Jói
LGTM
6 years, 11 months ago (2014-01-08 10:31:57 UTC) #13
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 12:49:58 UTC) #14
Message was sent while issue was closed. 
Change committed as 243541

Powered by Google App Engine
This is Rietveld 408576698