Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 122313006: TSAN: Disable failing EmbeddedTestServerThreadingTestInstantiation tests. (Closed)

Created:
6 years, 11 months ago by Lei Zhang
Modified:
6 years, 11 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

TSAN: Disable failing EmbeddedTestServerThreadingTestInstantiation tests. Valgrind: Remove obsolete suppressions. BUG=147755, 310348 NOTRY=true TBR=timurrrr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
TBR
6 years, 11 months ago (2014-01-06 23:36:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/122313006/1
6 years, 11 months ago (2014-01-06 23:39:33 UTC) #2
commit-bot: I haz the power
Change committed as 243202
6 years, 11 months ago (2014-01-06 23:41:58 UTC) #3
Timur Iskhodzhanov
6 years, 11 months ago (2014-01-07 11:57:12 UTC) #4
LGTM

2014/1/7  <thestig@chromium.org>:
> Reviewers: Timur Iskhodzhanov,
>
> Message:
> TBR
>
> Description:
> TSAN: Disable failing EmbeddedTestServerThreadingTestInstantiation tests.
> Valgrind: Remove obsolete suppressions.
>
> BUG=147755,310348
> NOTRY=true
> TBR=timurrrr@chromium.org
>
> Please review this at https://codereview.chromium.org/122313006/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files (+3, -16 lines):
>   M     tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
>   M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> ===================================================================
> --- tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> (revision 243199)
> +++ tools/valgrind/gtest_exclude/net_unittests.gtest-tsan_win32.txt
> (working copy)
> @@ -36,5 +36,8 @@
>  NetworkChangeNotifierWinTest.NetChangeWinSignal
>  NetworkChangeNotifierWinTest.NetChangeWinFailSignal*
>
> +# Fails frequently. crbug.com/310348
> +EmbeddedTestServerThreadingTestInstantiation.*
> +
>  # Hang: crbug.com/331468
>  MultiThreadedCertVerifierTest.DifferentCACerts
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 243199)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -4319,22 +4319,6 @@
>     fun:_ZN4base18MessagePumpAuraX1118GetDefaultXDisplayEv
>  }
>  {
> -   bug_147755_a
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN12PluginFinder18GetPluginInstallerERKN6webkit13WebPluginInfoE
> -   fun:_ZN11PluginPrefs30EnablePluginIfPossibleCallbackE*
> -}
> -{
> -   bug_147755_b
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN12PluginFinder17GetPluginMetadataERKN6webkit13WebPluginInfoE
> -   fun:_ZN11PluginPrefs12EnablePluginE*
> -   fun:_ZN15PluginPrefsTest25EnablePluginSynchronouslyE*
> -   fun:_ZN44PluginPrefsTest_UnifiedPepperFlashState_Test8TestBodyEv
> -}
> -{
>     bug_149734a
>     Memcheck:Leak
>     fun:malloc
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698