Issue 122313002: Possibly uninitialized SkRgnBuilder fStorage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122313002: Possibly uninitialized SkRgnBuilder fStorage. (Closed)

Created:
6 years, 11 months ago by f(malita)

Modified:
6 years, 11 months ago

Reviewers:
fmalita_google_do_not_use, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Possibly uninitialized SkRgnBuilder fStorage. fStorage needs to be initialized regardless of SkRgnBuilder::init()'s outcome - otherwise the destructor can end up freeing garbage. BUG=330293 R=reed@google.com Committed: http://code.google.com/p/skia/source/detail?r=12846

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/core/SkRegion_path.cpp	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/122313002/1

6 years, 11 months ago (2013-12-30 15:49:59 UTC) #3

Message was sent while issue was closed.

Change committed as 12846