Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223113004: Polish the menu animation (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
mpcomplete, Matt Perry
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Polish the menu animation - Delay the close of the menu by the appropriate amount. - Fade the menu items for equal amounts of time. - Contract the height of the menu just after each item fade. R=mpcomplete@chromium.org, mpcomplete@google.com Committed: https://chromium.googlesource.com/external/mojo/+/89780b75c538bf33eb601113e06a074700bb8f9b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M sky/sdk/lib/animation/animation_performance.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M sky/sdk/lib/base/debug.dart View 1 chunk +1 line, -1 line 2 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-14 20:48:53 UTC) #1
Matt Perry
lgtm https://codereview.chromium.org/1223113004/diff/1/sky/sdk/lib/base/debug.dart File sky/sdk/lib/base/debug.dart (right): https://codereview.chromium.org/1223113004/diff/1/sky/sdk/lib/base/debug.dart#newcode28 sky/sdk/lib/base/debug.dart:28: double timeDilation = 10.0; revert this
5 years, 5 months ago (2015-07-14 20:52:54 UTC) #3
abarth-chromium
https://codereview.chromium.org/1223113004/diff/1/sky/sdk/lib/base/debug.dart File sky/sdk/lib/base/debug.dart (right): https://codereview.chromium.org/1223113004/diff/1/sky/sdk/lib/base/debug.dart#newcode28 sky/sdk/lib/base/debug.dart:28: double timeDilation = 10.0; On 2015/07/14 at 20:52:54, Matt ...
5 years, 5 months ago (2015-07-14 20:55:13 UTC) #4
abarth-chromium
5 years, 5 months ago (2015-07-14 20:56:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
89780b75c538bf33eb601113e06a074700bb8f9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698