Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1223083002: Make RenderBlock painting match its hittesting (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make RenderBlock painting match its hittesting I added a clip in RenderBlock to make the painted pixels match the hittesting logic. This at least makes obvious all the numerous hittesting bugs in our system. :) I also moved demo_launcher to ScrollableList awesomeness. R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/ff823b784ab76d8e9957a815009da7e9d35d2bcf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M sky/sdk/example/demo_launcher/lib/main.dart View 3 chunks +9 lines, -11 lines 0 comments Download
M sky/sdk/lib/rendering/block.dart View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-08 20:44:22 UTC) #2
eseidel
5 years, 5 months ago (2015-07-08 20:47:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff823b784ab76d8e9957a815009da7e9d35d2bcf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698