Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1223073002: AnimatedContainer: generalized Container widget that handles animating values (Closed)

Created:
5 years, 5 months ago by Matt Perry
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

AnimatedContainer: generalized Container widget that handles animating values when they change via syncFields. Very early so far. Only supports animating shadow, position, and backgroundColor. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f66984e72a2b5db0f7c4db4f05829118defe6640

Patch Set 1 #

Total comments: 5

Patch Set 2 : abarth #

Patch Set 3 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -73 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/lib/animation/animation_performance.dart View 1 1 chunk +6 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/animated_component.dart View 2 chunks +0 lines, -23 lines 0 comments Download
A sky/sdk/lib/widgets/animated_container.dart View 1 1 chunk +112 lines, -0 lines 2 comments Download
M sky/sdk/lib/widgets/drawer.dart View 1 5 chunks +12 lines, -8 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 4 chunks +28 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Matt Perry
https://codereview.chromium.org/1223073002/diff/1/sky/sdk/example/stocks/lib/stock_home.dart File sky/sdk/example/stocks/lib/stock_home.dart (right): https://codereview.chromium.org/1223073002/diff/1/sky/sdk/example/stocks/lib/stock_home.dart#newcode260 sky/sdk/example/stocks/lib/stock_home.dart:260: Matrix4 transform = new Matrix4.identity(); Ignore this. I want ...
5 years, 5 months ago (2015-07-08 20:42:13 UTC) #2
abarth-chromium
https://codereview.chromium.org/1223073002/diff/1/sky/sdk/example/stocks/lib/stock_home.dart File sky/sdk/example/stocks/lib/stock_home.dart (right): https://codereview.chromium.org/1223073002/diff/1/sky/sdk/example/stocks/lib/stock_home.dart#newcode260 sky/sdk/example/stocks/lib/stock_home.dart:260: Matrix4 transform = new Matrix4.identity(); On 2015/07/08 at 20:42:13, ...
5 years, 5 months ago (2015-07-08 21:02:05 UTC) #3
Matt Perry
ready for another look https://codereview.chromium.org/1223073002/diff/1/sky/sdk/example/stocks/lib/stock_home.dart File sky/sdk/example/stocks/lib/stock_home.dart (right): https://codereview.chromium.org/1223073002/diff/1/sky/sdk/example/stocks/lib/stock_home.dart#newcode260 sky/sdk/example/stocks/lib/stock_home.dart:260: Matrix4 transform = new Matrix4.identity(); ...
5 years, 5 months ago (2015-07-08 21:41:03 UTC) #4
abarth-chromium
LGTM Much better https://codereview.chromium.org/1223073002/diff/40001/sky/sdk/lib/widgets/animated_container.dart File sky/sdk/lib/widgets/animated_container.dart (right): https://codereview.chromium.org/1223073002/diff/40001/sky/sdk/lib/widgets/animated_container.dart#newcode29 sky/sdk/lib/widgets/animated_container.dart:29: AnimatedComponent _component; We shouldn't have an ...
5 years, 5 months ago (2015-07-09 17:51:46 UTC) #5
Matt Perry
https://codereview.chromium.org/1223073002/diff/40001/sky/sdk/lib/widgets/animated_container.dart File sky/sdk/lib/widgets/animated_container.dart (right): https://codereview.chromium.org/1223073002/diff/40001/sky/sdk/lib/widgets/animated_container.dart#newcode29 sky/sdk/lib/widgets/animated_container.dart:29: AnimatedComponent _component; On 2015/07/09 17:51:46, abarth-chromium wrote: > We ...
5 years, 5 months ago (2015-07-09 17:59:17 UTC) #6
abarth-chromium
On 2015/07/09 at 17:59:17, mpcomplete wrote: > https://codereview.chromium.org/1223073002/diff/40001/sky/sdk/lib/widgets/animated_container.dart > File sky/sdk/lib/widgets/animated_container.dart (right): > > https://codereview.chromium.org/1223073002/diff/40001/sky/sdk/lib/widgets/animated_container.dart#newcode29 ...
5 years, 5 months ago (2015-07-09 18:00:20 UTC) #7
Matt Perry
5 years, 5 months ago (2015-07-09 18:12:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f66984e72a2b5db0f7c4db4f05829118defe6640 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698