Issue 1223053002: mv //sky/services/intents //sky/services/activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1223053002: mv //sky/services/intents //sky/services/activity (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1, eseidel

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

mv //sky/services/intents //sky/services/activity This interface is growing to expose many activity-related functions, more than just intents. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/444a524a6b051484fb3832a3cb5df398ffdc4ac5

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -214 lines)			Patch
M	sky/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/example/demo_launcher/apk/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/example/demo_launcher/apk/org/domokit/sky/demo/SkyDemoApplication.java	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/mojo/activity.dart	View	2 chunks	+11 lines, -10 lines	0 comments	Download
A +	sky/services/activity/BUILD.gn	View	4 chunks	+5 lines, -5 lines	0 comments	Download
A +	sky/services/activity/activity.mojom	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	sky/services/activity/src/org/domokit/activity/ActivityImpl.java	View	2 chunks	+13 lines, -14 lines	0 comments	Download
D	sky/services/intents/BUILD.gn	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	sky/services/intents/intents.mojom	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java	View	1 chunk	+0 lines, -95 lines	0 comments	Download
M	sky/shell/BUILD.gn	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyActivity.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/viewer/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

5 years, 5 months ago (2015-07-08 20:37:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
444a524a6b051484fb3832a3cb5df398ffdc4ac5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages