Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 12230054: Make TestWebIDBFactory allocate a separate WebIDBFactory per thread. (Closed)

Created:
7 years, 9 months ago by darin (slow to review)
Modified:
7 years, 9 months ago
Reviewers:
alecflett
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Make TestWebIDBFactory allocate a separate WebIDBFactory per thread. This allows the main WebKit thread and web worker threads to each get their own WebIDBFactory instance, which mimics the behavior when we let the WebIDBFactory be instantiated via the WebKitPlatformSupport::idbFactory() method. Avoid storing WebString on class that will be reached by multiple threads. This is a slight variation on the patch attempted here: https://chromiumcodereview.appspot.com/12181010 R=alecflett@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -84 lines) Patch
A webkit/support/test_webidbfactory.h View 1 chunk +55 lines, -0 lines 0 comments Download
A webkit/support/test_webidbfactory.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M webkit/support/webkit_support.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 5 chunks +4 lines, -13 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
7 years, 9 months ago (2013-02-15 16:04:40 UTC) #1
darin (slow to review)
One thing I realized is that webkit_support::GetAbsoluteWebStringFromUTF8Path is not necessary. ScopedTempDir already produces an absolute ...
7 years, 9 months ago (2013-02-15 20:16:10 UTC) #2
alecflett
On 2013/02/15 20:16:10, darin wrote: > One thing I realized is that webkit_support::GetAbsoluteWebStringFromUTF8Path is > ...
7 years, 9 months ago (2013-02-15 20:24:06 UTC) #3
darin (slow to review)
7 years, 9 months ago (2013-02-15 21:19:11 UTC) #4
Thanks.  FilePath just uses std::{w}string, so it is thread-safe.

-Darin


On Fri, Feb 15, 2013 at 12:24 PM, <alecflett@chromium.org> wrote:

> On 2013/02/15 20:16:10, darin wrote:
>
>> One thing I realized is that webkit_support::**
>> GetAbsoluteWebStringFromUTF8Pa**th
>>
> is
>
>> not necessary.  ScopedTempDir already produces an absolute FilePath, so we
>>
> just
>
>> need to convert that to a WebString.  This is what the GetDataDir function
>>
> does.
>
> lgtm - I don't know enough about FilePaths so I'm assuming you've got this
> right...
>
>
https://chromiumcodereview.**appspot.com/12230054/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698