Issue 1223003002: Remove unused variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1223003002: Remove unused variable. (Closed)

Created:
5 years, 5 months ago by qsr

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove unused variable. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4e9fd04dcb359de7c6b120a1f6d30d24dc3c31ab

Patch Set 1 #

Patch Set 2 : Fix calling site. #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	sky/sdk/example/demo_launcher/apk/org/domokit/sky/demo/SkyDemoApplication.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java	View		2 chunks	+1 line, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

qsr

Committed patchset #2 (id:20001) manually as 4e9fd04dcb359de7c6b120a1f6d30d24dc3c31ab (presubmit successful).

5 years, 5 months ago (2015-07-08 13:00:42 UTC) #2

abarth-chromium

5 years, 5 months ago (2015-07-08 14:27:37 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/1223003002/diff/20001/sky/services/intents/sr...
File sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java
(left):

https://codereview.chromium.org/1223003002/diff/20001/sky/services/intents/sr...
sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java:25:
private Context mContext;
Really we should add a comment explaining that sCurrentActivity isn't correct. 
The correct thing is to have mContext refer to the current activity and do have
separate instances of ActivityManagerImpl for each Android Activity.

Expand Messages | Collapse Messages