linux: Both gtk and the aura port should set the icon theme name.

linux: Both gtk and the aura port should set the icon theme name.

BUG=176103
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182748

[Lei Zhang, 2013-02-13 21:54:58]

lgtm with nits/suggestions below:

https://codereview.chromium.org/12230026/diff/1/base/nix/mime_util_xdg.cc
File base/nix/mime_util_xdg.cc (left):

https://codereview.chromium.org/12230026/diff/1/base/nix/mime_util_xdg.cc#old...
base/nix/mime_util_xdg.cc:605: // If the theme name is already loaded, do
nothing. Chrome doesn't respond
Is this statement still true? How about for Aura? Maybe return if
|icon_theme_name_| is already set?

https://codereview.chromium.org/12230026/diff/1/chrome/browser/icon_loader.cc
File chrome/browser/icon_loader.cc (right):

https://codereview.chromium.org/12230026/diff/1/chrome/browser/icon_loader.cc...
chrome/browser/icon_loader.cc:11: #if defined(TOOLKIT_GTK)
You can remove this too since we're no longer calling
base::nix::DetectGtkTheme().

[Elliot Glaysher, 2013-02-13 22:04:36]

done.

https://codereview.chromium.org/12230026/diff/1/base/nix/mime_util_xdg.cc
File base/nix/mime_util_xdg.cc (left):

https://codereview.chromium.org/12230026/diff/1/base/nix/mime_util_xdg.cc#old...
base/nix/mime_util_xdg.cc:605: // If the theme name is already loaded, do
nothing. Chrome doesn't respond
On 2013/02/13 21:54:58, Lei Zhang wrote:
> Is this statement still true? How about for Aura? Maybe return if
> |icon_theme_name_| is already set?

What I'd like to happen eventually is have the xdg layer track when the icon
theme changes and reload its data, but since that hasn't happened yet, I think
you're right that I shouldn't change it after first load.

[commit-bot: I haz the power, 2013-02-13 22:06:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/12230026/11001

[commit-bot: I haz the power, 2013-02-13 22:06:56]

Presubmit check for 12230026-11001 failed and returned exit status 1.

INFO:root:Found 7 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/base/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/chrome/browser/ui/libgtk2ui/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base

Presubmit checks took 1.5s to calculate.

[Elliot Glaysher, 2013-02-13 22:12:51]

brettw: owners stamp?

[brettw, 2013-02-14 00:39:33]

LGTM rubberstamp

[commit-bot: I haz the power, 2013-02-14 00:55:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/12230026/11001

[commit-bot: I haz the power, 2013-02-14 01:14:58]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, cacheinvalidation_unittests, check_deps, chromedriver2_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, nacl_integration, net_unittests, ppapi_unittests,
printing_unittests, remoting_unittests, sandbox_linux_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-02-14 17:32:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/12230026/11001

[commit-bot: I haz the power, 2013-02-14 22:22:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/12230026/11001

[commit-bot: I haz the power, 2013-02-15 11:50:48]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...