Issue 12230020: Adding virtual destructor to CloudPrintURLFetcherFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12230020: Adding virtual destructor to CloudPrintURLFetcherFactory (Closed)

Created:
7 years, 10 months ago by Noam Samuel (WRONG ACCOUNT)

Modified:
7 years, 10 months ago

Reviewers:
gene, Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Adding virtual destructor to CloudPrintURLFetcherFactory Adding empty virtual destructor to CloudPrintURLFetcherFactory to align it with Chromium coding style. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182332

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/service/cloud_print/cloud_print_url_fetcher.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/service/cloud_print/cloud_print_url_fetcher.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Noam Samuel (WRONG ACCOUNT)

As per the discussion on https://codereview.chromium.org/12248009/, adding a virtual destructor to CloudPrintURLFetcherFactory.

7 years, 10 months ago (2013-02-13 18:33:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@google.com/12230020/1

7 years, 10 months ago (2013-02-13 18:48:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@google.com/12230020/1

7 years, 10 months ago (2013-02-13 19:40:39 UTC) #4

Message was sent while issue was closed.

Change committed as 182332