Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 12230014: Assign FILE_PATH_LITERALS to FilePath::CharType[] arrays. (Closed)

Created:
7 years, 10 months ago by Joao da Silva
Modified:
7 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Assign FILE_PATH_LITERALS to FilePath::CharType[] arrays. Fixed a couple of places that assigned FILE_PATH_LITERALS to char[] arrays. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182466

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google/google_util_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_paths.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
I was asked to clean this up on another CL, please review. Thanks!
7 years, 10 months ago (2013-02-13 16:16:49 UTC) #1
jochen (gone - plz use gerrit)
lgtm please add a BUG= line
7 years, 10 months ago (2013-02-13 16:19:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12230014/1
7 years, 10 months ago (2013-02-13 17:52:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12230014/1
7 years, 10 months ago (2013-02-13 19:38:37 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/common/chrome_paths.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-13 19:38:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12230014/2017
7 years, 10 months ago (2013-02-14 10:01:02 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 15:00:48 UTC) #7
Message was sent while issue was closed.
Change committed as 182466

Powered by Google App Engine
This is Rietveld 408576698