Files.app: add mock namespaces and constructors to mock_chrome.js for test.

Files.app: add mock namespaces and constructors to mock_chrome.js for test.

BUG=175657
TEST=mock Files.app works.
TBR=mtomasz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182235

[mtomasz, 2013-02-14 05:24:22]

This change breaks harness.

[mtomasz, 2013-02-14 05:26:24]

https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/mock_chrome.js (right):

https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/mock_chrome.js:909: var v8Intl = {};
Why do we mock this? It is always available on chrome.

[yoshiki, 2013-02-14 06:20:28]

https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/mock_chrome.js (right):

https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/mock_chrome.js:909: var v8Intl = {};
On 2013/02/14 05:26:24, mtomasz wrote:
> Why do we mock this? It is always available on chrome.

It needs to compile with closure compiler, but not need on chrome as you said.
I'll separate them to another file (maybe mock_v8intl.js).

[mtomasz, 2013-02-14 07:23:24]

On 2013/02/14 06:20:28, yoshiki wrote:
>
https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
> File chrome/browser/resources/file_manager/js/mock_chrome.js (right):
> 
>
https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
> chrome/browser/resources/file_manager/js/mock_chrome.js:909: var v8Intl = {};
> On 2013/02/14 05:26:24, mtomasz wrote:
> > Why do we mock this? It is always available on chrome.
> 
> It needs to compile with closure compiler, but not need on chrome as you said.
> I'll separate them to another file (maybe mock_v8intl.js).

The problem is, that this mock overrides real chrome's object, so later I get js
errors, since harness uses that methods.

[mtomasz, 2013-02-14 07:24:10]

On 2013/02/14 07:23:24, mtomasz wrote:
> On 2013/02/14 06:20:28, yoshiki wrote:
> >
>
https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
> > File chrome/browser/resources/file_manager/js/mock_chrome.js (right):
> > 
> >
>
https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
> > chrome/browser/resources/file_manager/js/mock_chrome.js:909: var v8Intl =
{};
> > On 2013/02/14 05:26:24, mtomasz wrote:
> > > Why do we mock this? It is always available on chrome.
> > 
> > It needs to compile with closure compiler, but not need on chrome as you
said.
> > I'll separate them to another file (maybe mock_v8intl.js).
> 
> The problem is, that this mock overrides real chrome's object, so later I get
js
> errors, since harness uses that methods.

Do you mean separate file an conditional <link> later? Looks like an overkill,
but I don't have any better idea as for now...

[mtomasz, 2013-02-14 07:31:51]

On 2013/02/14 07:24:10, mtomasz wrote:
> On 2013/02/14 07:23:24, mtomasz wrote:
> > On 2013/02/14 06:20:28, yoshiki wrote:
> > >
> >
>
https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
> > > File chrome/browser/resources/file_manager/js/mock_chrome.js (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
> > > chrome/browser/resources/file_manager/js/mock_chrome.js:909: var v8Intl =
> {};
> > > On 2013/02/14 05:26:24, mtomasz wrote:
> > > > Why do we mock this? It is always available on chrome.
> > > 
> > > It needs to compile with closure compiler, but not need on chrome as you
> said.
> > > I'll separate them to another file (maybe mock_v8intl.js).
> > 
> > The problem is, that this mock overrides real chrome's object, so later I
get
> js
> > errors, since harness uses that methods.
> 
> Do you mean separate file an conditional <link> later? Looks like an overkill,
> but I don't have any better idea as for now...

How about just:
var v8Intl = window['v8Intl'] || {}; ?

and later if necessary:
v8Intl.Collator = v8Intl['Collator'] || function(locales, options) {}; ?

I haven't checked if it satisfies the closure compiler. Anyway, up to you.

[yoshiki, 2013-02-14 07:34:36]

On 2013/02/14 07:23:24, mtomasz wrote:
> On 2013/02/14 06:20:28, yoshiki wrote:
> >
>
https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
> > File chrome/browser/resources/file_manager/js/mock_chrome.js (right):
> > 
> >
>
https://codereview.chromium.org/12230013/diff/1/chrome/browser/resources/file...
> > chrome/browser/resources/file_manager/js/mock_chrome.js:909: var v8Intl =
{};
> > On 2013/02/14 05:26:24, mtomasz wrote:
> > > Why do we mock this? It is always available on chrome.
> > 
> > It needs to compile with closure compiler, but not need on chrome as you
said.
> > I'll separate them to another file (maybe mock_v8intl.js).
> 
> The problem is, that this mock overrides real chrome's object, so later I get
js
> errors, since harness uses that methods.

I got it. I'll revert this patch and will create an another file like
mock_for_non_chrome.js.