Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 12230011: Fix jemalloc c4334 warnings when compiling win64 (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Will Harris
Visibility:
Public.

Description

Fix jemalloc c4334 warnings when compiling win64 BUG=166496 TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182353

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/jemalloc/chromium/jemalloc.c View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jschuh
Just forcing the right type to avoid warnings on the undefined promotion.
7 years, 10 months ago (2013-02-13 14:07:12 UTC) #1
jar (doing other things)
lgtm
7 years, 10 months ago (2013-02-13 22:02:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12230011/1
7 years, 10 months ago (2013-02-13 22:06:43 UTC) #3
commit-bot: I haz the power
Presubmit check for 12230011-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-13 22:06:47 UTC) #4
jschuh
@cpu - I assume it's okay to TBR an eng-reviewer in the case of a ...
7 years, 10 months ago (2013-02-13 22:47:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12230011/1
7 years, 10 months ago (2013-02-13 22:51:40 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) build http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=36082
7 years, 10 months ago (2013-02-13 23:31:27 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 23:44:09 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698