Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 12230010: Linux: update infobar message shown on systems no longer supported. (Closed)

Created:
7 years, 10 months ago by Paweł Hajdan Jr.
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: update infobar message shown on systems no longer supported. TBR=mal, cpu BUG=175842 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
7 years, 10 months ago (2013-02-13 13:52:58 UTC) #1
Mark Larson
7 years, 10 months ago (2013-02-13 18:59:38 UTC) #2
LGTM

On Wed, Feb 13, 2013 at 5:52 AM, <phajdan.jr@chromium.org> wrote:

> Reviewers: Mark Larson, cpu,
>
> Description:
> Linux: update infobar message shown on systems no longer supported.
>
> TBR=mal, cpu
>
> BUG=175842
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=182210<https://src.chromium.org/viewvc/chrome?view=rev&revision=182210>
>
> Please review this at
https://codereview.chromium.**org/12230010/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/app/chromium_strings.**grd
>   M chrome/app/google_chrome_**strings.grd
>
>
> Index: chrome/app/chromium_strings.**grd
> diff --git a/chrome/app/chromium_strings.**grd
> b/chrome/app/chromium_strings.**grd
> index eb079ad8d63c397754685abc08bffb**dcff253e3b..**
> 284681d387b54fa995a90ee8ced6e9**a446a03aaf 100644
> --- a/chrome/app/chromium_strings.**grd
> +++ b/chrome/app/chromium_strings.**grd
> @@ -683,7 +683,7 @@ Chromium is unable to recover your settings.
>
>        <!-- Obsolete System info bar -->
>        <message name="IDS_SYSTEM_OBSOLETE_**MESSAGE" desc="Message shown
> when your OS is no longer supported. This messages is followed by a 'Learn
> more' link.">
> -         Chromium is no longer updating because your operating system is
> obsolete.
> +         Chromium has stopped updating and no longer supports this
> version of your operating system.
>        </message>
>
>        <!-- about:memory -->
> Index: chrome/app/google_chrome_**strings.grd
> diff --git a/chrome/app/google_chrome_**strings.grd
> b/chrome/app/google_chrome_**strings.grd
> index 29e41b7c3a8e8d4903a5b489d6ce83**e6e11749e7..**
> 47ec8e9f79deba608bb8412a4db45c**7914a2d4d1 100644
> --- a/chrome/app/google_chrome_**strings.grd
> +++ b/chrome/app/google_chrome_**strings.grd
> @@ -607,7 +607,7 @@ Google Chrome is unable to recover your settings.
>
>        <!-- Obsolete System info bar -->
>        <message name="IDS_SYSTEM_OBSOLETE_**MESSAGE" desc="Message shown
> when your OS is no longer supported. This messages is followed by a 'Learn
> more' link.">
> -         Google Chrome is no longer updating because your operating
> system is obsolete.
> +         Google Chrome has stopped updating and no longer supports this
> version of your operating system.
>        </message>
>
>        <!-- about:memory -->
>
>
>

Powered by Google App Engine
This is Rietveld 408576698