components/certificate_transparency/BUILD.gn - Issue 1222953002: Certificate Transparency: Add STH Fetching capability.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/certificate_transparency/BUILD.gn

Issue 1222953002: Certificate Transparency: Add STH Fetching capability. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding OWNERS Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("filename_util") {	5 static_library("certificate_transparency") {
	sdefresne 2015/08/07 16:39:08 Any reason for using static_library and not source Any reason for using static_library and not source_set? source_set is generally preferred to static_library (according to dpranke, source_set is what you want to use in 99% of the case). Eran Messeri 2015/08/17 16:33:35 Done - no reason not to use source_set here. Show quoted text On 2015/08/07 16:39:08, sdefresne wrote: > Any reason for using static_library and not source_set? source_set is generally > preferred to static_library (according to dpranke, source_set is what you want > to use in 99% of the case). Done - no reason not to use source_set here.
6 sources = [	6 sources = [

7 "filename_util.cc",	7 "log_proof_fetcher.cc",

8 "filename_util.h",	8 "log_proof_fetcher.h",

9 ]	9 ]

10	10

11 deps = [	11 deps = [

12 "//base",	12 "//base",

13 "//url",	13 "//components/safe_json",
sdefresne 2015/08/07 16:39:08 There is an #include of url/gurl.h in components/c There is an #include of url/gurl.h in components/certificate_transparency/log_proof_fetcher.cc, so I think you need the dependency on //url. Didn't gn warn about this? Eran Messeri 2015/08/17 16:33:35 Done - I didn't compile it locally using gn, I rel Show quoted text On 2015/08/07 16:39:08, sdefresne wrote: > There is an #include of url/gurl.h in > components/certificate_transparency/log_proof_fetcher.cc, so I think you need > the dependency on //url. Didn't gn warn about this? Done - I didn't compile it locally using gn, I relied on the bots.
	14 "//net",

14 ]	15 ]

15 }	16 }
	sdefresne 2015/08/07 16:39:08 Can you also add unit_test target here and into // Can you also add unit_test target here and into //components/BUILD.gn? Eran Messeri 2015/08/17 16:33:35 Done. Show quoted text On 2015/08/07 16:39:08, sdefresne wrote: > Can you also add unit_test target here and into //components/BUILD.gn? Done.
OLD	NEW

« components/certificate_transparency.gypi ('K') | « components/certificate_transparency.gypi ('k') | components/certificate_transparency/DEPS » ('j') | no next file with comments »