Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1222913006: Attempt to stop sky_server before starting it to avoid confusion and the warning message. (Closed)

Created:
5 years, 5 months ago by iansf
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Attempt to stop sky_server before starting it to avoid confusion and the warning message. R=abarth@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c7717ead00a6990f643b413ac0c1541f671d369a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sky/tools/shelldb View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-07 22:46:23 UTC) #2
iansf
5 years, 5 months ago (2015-07-07 22:47:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7717ead00a6990f643b413ac0c1541f671d369a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698