Introduce the PushSubscription.curve25519dh attribute (1/3)

public/platform/modules/push_messaging/WebPushSubscription.h

Index: public/platform/modules/push_messaging/WebPushSubscription.h
diff --git a/public/platform/modules/push_messaging/WebPushSubscription.h b/public/platform/modules/push_messaging/WebPushSubscription.h
index b582bf4c92b11a7dab59a96c287ae03e2ca29569..f6e2549953adcf46ce0b89e83e3a3cc432e81f5b 100644
--- a/public/platform/modules/push_messaging/WebPushSubscription.h
+++ b/public/platform/modules/push_messaging/WebPushSubscription.h
@@ -8,19 +8,25 @@
 #include "public/platform/WebCommon.h"
 #include "public/platform/WebString.h"
 #include "public/platform/WebURL.h"
+#include "public/platform/WebVector.h"
 
 namespace blink {
 
 struct WebPushSubscription {
-    explicit WebPushSubscription(const WebURL& endpoint)
+    WebPushSubscription(const WebURL& endpoint, const WebVector<unsigned char>& curve25519dh)

[Mike West, 2015/07/10 08:06:55]

Might be worth adding a comment that |endpoint| must contain a subscription id?

[Peter Beverloo, 2015/07/13 13:58:14]

I've mentioned that it must be unique for each subscription. (Theoretically a
push service could work on something other than a subscription id.)

         : endpoint(endpoint)
+        , curve25519dh(curve25519dh)
     {
     }
 
-    // TODO(peter): Remove this constructor when the embedder switched over to the one above.
-    BLINK_PLATFORM_EXPORT WebPushSubscription(const WebString& endpointWithoutSubscriptionId, const WebString& subscriptionId);
+    // TODO(peter): Remove this constructor when the embedder doesn't use it anymore.
+    explicit WebPushSubscription(const WebURL& endpoint)
+        : endpoint(endpoint)
+    {
+    }
 
     WebURL endpoint;
+    WebVector<unsigned char> curve25519dh;

[johnme, 2015/07/09 11:00:15]

Actually, this name is a little cryptic. Presumably it's the (secret) public
encryption key with which sent messages should be encrypted.

[Peter Beverloo, 2015/07/09 14:28:34]

I clarified the CLs description.

 };
 
 } // namespace blink