Make frequent type checks (instanceof) faster by adding dedicated instanceof methods; improves dart…

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/bit_vector.h"
 #include "vm/class_finalizer.h"
@@ skipping 1793 matching lines @@
     // Must evaluate left side.
     EffectGraphVisitor for_left_value(owner());
     node->left()->Visit(&for_left_value);
     Append(for_left_value);
     ReturnDefinition(new(Z) ConstantInstr(Bool::Get(!negate_result)));
     return;
   }
   ValueGraphVisitor for_left_value(owner());
   node->left()->Visit(&for_left_value);
   Append(for_left_value);
+
+  if (!FLAG_warn_on_javascript_compatibility) {
+    if (type.IsNumberType() || type.IsIntType() || type.IsDoubleType() ||
+        type.IsSmiType() || type.IsStringType()) {
+      String& method_name = String::ZoneHandle(Z);
+      if (type.IsNumberType()) {
+        method_name = Symbols::_instanceOfNum().raw();
+      } else if (type.IsIntType()) {
+        method_name = Symbols::_instanceOfInt().raw();
+      } else if (type.IsDoubleType()) {
+        method_name = Symbols::_instanceOfDouble().raw();
+      } else if (type.IsSmiType()) {
+        method_name = Symbols::_instanceOfSmi().raw();
+      } else if (type.IsStringType()) {
+        method_name = Symbols::_instanceOfString().raw();
+      }
+      ASSERT(!method_name.IsNull());
+      PushArgumentInstr* push_left = PushArgument(for_left_value.value());
+      ZoneGrowableArray<PushArgumentInstr*>* arguments =
+          new(Z) ZoneGrowableArray<PushArgumentInstr*>(2);
+      arguments->Add(push_left);
+      const Bool& negate = Bool::Get(node->kind() == Token::kISNOT);
+      Value* negate_arg = Bind(new(Z) ConstantInstr(negate));
+      arguments->Add(PushArgument(negate_arg));
+      const intptr_t kNumArgsChecked = 1;
+      InstanceCallInstr* call = new(Z) InstanceCallInstr(
+          node->token_pos(),
+          Library::PrivateCoreLibName(method_name),
+          node->kind(),
+          arguments,
+          Object::null_array(),  // No argument names.
+          kNumArgsChecked,
+          owner()->ic_data_array());
+      ReturnDefinition(call);
+      return;
+    }
+  }
+
   PushArgumentInstr* push_left = PushArgument(for_left_value.value());
   PushArgumentInstr* push_instantiator = NULL;
   PushArgumentInstr* push_type_args = NULL;
   if (type.IsInstantiated()) {
     push_instantiator = PushArgument(BuildNullValue());
     push_type_args = PushArgument(BuildNullValue());
   } else {
     BuildTypecheckPushArguments(node->token_pos(),
                                 &push_instantiator,
                                 &push_type_args);
   }
   ZoneGrowableArray<PushArgumentInstr*>* arguments =
       new(Z) ZoneGrowableArray<PushArgumentInstr*>(5);
   arguments->Add(push_left);
   arguments->Add(push_instantiator);
   arguments->Add(push_type_args);
   ASSERT(!node->right()->AsTypeNode()->type().IsNull());
-  Value* type_arg = Bind(
-      new(Z) ConstantInstr(node->right()->AsTypeNode()->type()));
-  arguments->Add(PushArgument(type_arg));
+  Value* type_const = Bind(new(Z) ConstantInstr(type));
+  arguments->Add(PushArgument(type_const));
   const Bool& negate = Bool::Get(node->kind() == Token::kISNOT);
   Value* negate_arg = Bind(new(Z) ConstantInstr(negate));
   arguments->Add(PushArgument(negate_arg));
   const intptr_t kNumArgsChecked = 1;
   InstanceCallInstr* call = new(Z) InstanceCallInstr(
       node->token_pos(),
       Library::PrivateCoreLibName(Symbols::_instanceOf()),
       node->kind(),
       arguments,
       Object::null_array(),  // No argument names.
@@ skipping 2921 matching lines @@
   Report::MessageF(Report::kBailout,
                    Script::Handle(function.script()),
                    function.token_pos(),
                    "FlowGraphBuilder Bailout: %s %s",
                    String::Handle(function.name()).ToCString(),
                    reason);
   UNREACHABLE();
 }
 
 }  // namespace dart